Skip to content

Commit 76a5e0a

Browse files
author
Pearl Dsilva
committed
update log and timout
1 parent 4730e59 commit 76a5e0a

3 files changed

Lines changed: 16 additions & 12 deletions

File tree

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6984,7 +6984,7 @@ static boolean checkIfVolumeGroupIsClustered(String vgName) {
69846984
try {
69856985
// Use vgs with --noheadings and -o attr to get VG attributes
69866986
OutputInterpreter.AllLinesParser parser = new OutputInterpreter.AllLinesParser();
6987-
Script vgsCmd = new Script("vgs", 5000, LOGGER);
6987+
Script vgsCmd = new Script("vgs", 10000, LOGGER);
69886988
vgsCmd.add("--noheadings");
69896989
vgsCmd.add("--unbuffered");
69906990
vgsCmd.add("-o");

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ public KVMPhysicalDisk createPhysicalDisk(String name, KVMStoragePool pool,
175175
public boolean connectPhysicalDisk(String name, KVMStoragePool pool, Map<String, String> details, boolean isVMMigrate) {
176176
if (isVMMigrate) {
177177
logger.info("Activating CLVM/CLVM_NG volume {} in shared mode for VM migration", name);
178-
Script activateVol = new Script("lvchange", 5000, logger);
178+
Script activateVol = new Script("lvchange", 10000, logger);
179179
activateVol.add("-asy");
180180
activateVol.add(pool.getLocalPath() + File.separator + name);
181181
String result = activateVol.execute();
@@ -269,7 +269,7 @@ private StoragePool createCLVMStoragePool(Connect conn, String uuid, String host
269269
String volgroupName = path;
270270
volgroupName = volgroupName.replaceFirst("^/", "");
271271

272-
Script checkVgExists = new Script("vgs", 5000, logger);
272+
Script checkVgExists = new Script("vgs", 10000, logger);
273273
checkVgExists.add("--noheadings");
274274
checkVgExists.add("-o", "vg_name");
275275
checkVgExists.add(volgroupName);
@@ -315,7 +315,7 @@ private void setPoolCapacityFromVgStats(LibvirtStoragePool pool, long[] vgStats,
315315
}
316316

317317
private long[] getVgStats(String vgName) {
318-
Script getVgStats = new Script("vgs", 5000, logger);
318+
Script getVgStats = new Script("vgs", 10000, logger);
319319
getVgStats.add("--noheadings");
320320
getVgStats.add("--units", "b");
321321
getVgStats.add("--nosuffix");
@@ -470,7 +470,7 @@ private KVMPhysicalDisk getPhysicalDiskViaDirectBlockDevice(String volumeUuid, K
470470

471471
private void verifyLvExistsInVg(String volumeUuid, String vgName) {
472472
logger.debug("Checking if volume {} exists in VG {}", volumeUuid, vgName);
473-
Script checkLvCmd = new Script("/usr/sbin/lvs", 5000, logger);
473+
Script checkLvCmd = new Script("/usr/sbin/lvs", 10000, logger);
474474
checkLvCmd.add("--noheadings");
475475
checkLvCmd.add("--unbuffered");
476476
checkLvCmd.add(vgName + "/" + volumeUuid);
@@ -551,7 +551,7 @@ private void ensureTemplateAccessibility(String volumeUuid, String lvPath, KVMSt
551551

552552
private long getClvmVolumeSize(String lvPath) {
553553
try {
554-
Script lvsCmd = new Script("/usr/sbin/lvs", 5000, logger);
554+
Script lvsCmd = new Script("/usr/sbin/lvs", 10000, logger);
555555
lvsCmd.add("--noheadings");
556556
lvsCmd.add("--units");
557557
lvsCmd.add("b");
@@ -670,7 +670,7 @@ private String getClvmBackingFile(KVMPhysicalDisk template, KVMStoragePool destP
670670
*/
671671
private void ensureTemplateLvInSharedMode(String templatePath, boolean throwOnFailure) {
672672
try {
673-
Script checkLvs = new Script("lvs", Duration.millis(5000), logger);
673+
Script checkLvs = new Script("lvs", Duration.millis(10000), logger);
674674
checkLvs.add("--noheadings");
675675
checkLvs.add("-o", "lv_attr");
676676
checkLvs.add(templatePath);
@@ -882,7 +882,7 @@ private KVMPhysicalDisk createClvmNgDiskWithBacking(String volumeUuid, int timeo
882882
}
883883

884884
private boolean lvExists(String lvPath) {
885-
Script checkLv = new Script("lvs", Duration.millis(5000), logger);
885+
Script checkLv = new Script("lvs", Duration.millis(10000), logger);
886886
checkLv.add("--noheadings");
887887
checkLv.add("--unbuffered");
888888
checkLv.add(lvPath);
@@ -954,7 +954,7 @@ private boolean cleanupCLVMVolume(String uuid, KVMStoragePool pool) {
954954
String lvPath = "/dev/" + vgName + "/" + uuid;
955955
logger.debug("Volume path: {}", lvPath);
956956

957-
Script checkLvs = new Script("lvs", 5000, logger);
957+
Script checkLvs = new Script("lvs", 10000, logger);
958958
checkLvs.add("--noheadings");
959959
checkLvs.add("--unbuffered");
960960
checkLvs.add(lvPath);
@@ -979,7 +979,7 @@ private boolean cleanupCLVMVolume(String uuid, KVMStoragePool pool) {
979979
}
980980

981981
logger.info("Step 2: Removing volume {}", uuid);
982-
Script removeLv = new Script("lvremove", 10000, logger);
982+
Script removeLv = new Script("lvremove", 30000, logger);
983983
removeLv.add("-f");
984984
removeLv.add(lvPath);
985985

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1267,7 +1267,7 @@ private boolean deleteClvmSnapshot(String snapshotPath, StoragePoolType poolType
12671267

12681268
// Use managesnapshot.sh script for deletion (consistent with create/backup)
12691269
// Script handles MD5 transformation and pool-specific commands internally
1270-
Script deleteCommand = new Script(_manageSnapshotPath, 10000, logger);
1270+
Script deleteCommand = new Script(_manageSnapshotPath, 30000, logger);
12711271
deleteCommand.add("-d", volumePath);
12721272
deleteCommand.add("-n", snapshotUuid);
12731273

@@ -1308,7 +1308,11 @@ private void deleteSnapshotOnPrimary(final CopyCommand cmd, final SnapshotObject
13081308
// Both CLVM and CLVM_NG use the same deletion method via managesnapshot.sh script
13091309
boolean cleanedUp = deleteClvmSnapshot(snapshotPath, primaryPool.getType(), false);
13101310
if (!cleanedUp) {
1311-
logger.info("No need to delete {} snapshot on primary as it doesn't exist: {}", primaryPool.getType(), snapshotPath);
1311+
String[] parsedPath = parseClvmSnapshotPath(snapshotPath, primaryPool.getType());
1312+
String snapMd5 = (parsedPath != null) ? computeMd5Hash(parsedPath[2]) : computeMd5Hash(snapshotPath);
1313+
logger.warn("Deletion of Snapshot: {} on primary store may have failed as it doesn't exist: {} " +
1314+
"(MD5 of snapshot UUID: {} - admins can use this to manually locate and delete the LV via managesnapshot.sh or lvremove)",
1315+
primaryPool.getType(), snapshotPath, snapMd5);
13121316
}
13131317
} else {
13141318
Files.deleteIfExists(Paths.get(snapshotPath));

0 commit comments

Comments
 (0)