Prevent starting a VM in destroyed state (or any state but Stopped) (#5165)

Pearl1594 · web-flow · commit 3fd92502bb31 · 2021-07-09T15:11:30.000+05:30
* Prevent starting a VM in destroyed state (or any state but Stopped)
diff --git a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -881,8 +881,9 @@ public Ternary<VMInstanceVO, ReservationContext, ItWorkVO> doInTransaction(final
             }
 
             if (state != State.Stopped) {
-                s_logger.debug("VM " + vm + " is not in a state to be started: " + state);
-                return null;
+                String msg = String.format("Cannot start %s in %s state", vm, state);
+                s_logger.warn(msg);
+                throw new CloudRuntimeException(msg);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -881,8 +881,9 @@ public Ternary<VMInstanceVO, ReservationContext, ItWorkVO> doInTransaction(final`
`881`	`881`	`}`
`882`	`882`
`883`	`883`	`if (state != State.Stopped) {`
`884`		`- s_logger.debug("VM " + vm + " is not in a state to be started: " + state);`
`885`		`- return null;`
	`884`	`+ String msg = String.format("Cannot start %s in %s state", vm, state);`
	`885`	`+ s_logger.warn(msg);`
	`886`	`+ throw new CloudRuntimeException(msg);`
`886`	`887`	`}`
`887`	`888`	`}`
`888`	`889`