address comments

Author: Pearl1594

api/src/main/java/org/apache/cloudstack/api/response/BackupOfferingResponse.java

@@ -62,12 +62,12 @@ public class BackupOfferingResponse extends BaseResponse {
     private String zoneName;
 
     @SerializedName(ApiConstants.DOMAIN_ID)
-    @Param(description = "the domain ID(s) this disk offering belongs to. Ignore this information as it is not currently applicable.",
+    @Param(description = "the domain ID(s) this backup offering belongs to.",
     since = "4.23.0")
     private String domainId;
 
     @SerializedName(ApiConstants.DOMAIN)
-    @Param(description = "the domain name(s) this disk offering belongs to. Ignore this information as it is not currently applicable.",
+    @Param(description = "the domain name(s) this backup offering belongs to.",
     since = "4.23.0")
     private String domain;
 

engine/schema/src/main/java/org/apache/cloudstack/backup/dao/BackupOfferingDetailsDao.java

@@ -28,5 +28,5 @@ public interface BackupOfferingDetailsDao extends GenericDao<BackupOfferingDetai
     List<Long> findZoneIds(final long resourceId);
     String getDetail(Long backupOfferingId, String key);
     List<Long> findOfferingIdsByDomainIds(List<Long> domainIds);
-    void updateBackupOfferingDetails(long backupOfferingId, List<Long> filteredDomainIds);
+    void updateBackupOfferingDomainIdsDetail(long backupOfferingId, List<Long> filteredDomainIds);
 }

engine/schema/src/main/java/org/apache/cloudstack/backup/dao/BackupOfferingDetailsDaoImpl.java

@@ -79,7 +79,7 @@ public List<Long> findOfferingIdsByDomainIds(List<Long> domainIds) {
 
     @DB
     @Override
-    public void updateBackupOfferingDetails(long backupOfferingId, List<Long> filteredDomainIds) {
+    public void updateBackupOfferingDomainIdsDetail(long backupOfferingId, List<Long> filteredDomainIds) {
     SearchBuilder<BackupOfferingDetailsVO> sb = createSearchBuilder();
         List<BackupOfferingDetailsVO> detailsVO = new ArrayList<>();
         sb.and("offeringId", sb.entity().getResourceId(), SearchCriteria.Op.EQ);

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java

@@ -2252,7 +2252,7 @@ private void updateBackupOfferingDomainDetails(Long id, List<Long> filteredDomai
         }
 
         if(!filteredDomainIds.equals(existingDomainIds)) {
-            backupOfferingDetailsDao.updateBackupOfferingDetails(id, filteredDomainIds);
+            backupOfferingDetailsDao.updateBackupOfferingDomainIdsDetail(id, filteredDomainIds);
         }
     }
 

server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java

@@ -2231,7 +2231,7 @@ public void testUpdateBackupOfferingPersistsDomainDetailsWhenProvided() {
 
         BackupOffering updated = backupManager.updateBackupOffering(cmd);
 
-        verify(backupOfferingDetailsDao, times(1)).updateBackupOfferingDetails(id, List.of(domainId));
+        verify(backupOfferingDetailsDao, times(1)).updateBackupOfferingDomainIdsDetail(id, List.of(domainId));
     }
 
     @Test