sonar alerts and other suggestions

Author: Daan Hoogland

engine/components-api/src/main/java/com/cloud/storage/StorageManager.java

@@ -179,10 +179,10 @@ public interface StorageManager extends StorageService {
     ConfigKey<Integer> VmDiskThrottlingIopsWriteRate = new ConfigKey<>("Advanced", Integer.class, "vm.disk.throttling.iops_write_rate", "0",
             "Default disk I/O writerate in requests per second allowed in User vm's disk.", true);
 
-    ConfigKey<Integer> VmDiskThrottlingBytesReadRate = new ConfigKey<>("Advanced", Integer.class, "vm.disk.throttling.bytes_read_rate", "0",
+    ConfigKey<Long> VmDiskThrottlingBytesReadRate = new ConfigKey<>("Advanced", Long.class, "vm.disk.throttling.bytes_read_rate", "0",
             "Default disk I/O read rate in bytes per second allowed in User vm's disk.", true);
 
-    ConfigKey<Integer> VmDiskThrottlingBytesWriteRate = new ConfigKey<>("Advanced", Integer.class, "vm.disk.throttling.bytes_write_rate", "0",
+    ConfigKey<Long> VmDiskThrottlingBytesWriteRate = new ConfigKey<>("Advanced", Long.class, "vm.disk.throttling.bytes_write_rate", "0",
             "Default disk I/O writerate in bytes per second allowed in User vm's disk.", true);
 
     ConfigKey<Integer> ExpungeWorkers = new ConfigKey<>("Advanced", Integer.class, "expunge.workers", "1",

plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/manager/BaremetalManager.java

@@ -41,9 +41,9 @@ public interface BaremetalManager extends Manager, PluggableService {
             "After starting provision process, periodcially echo security agent installed in the template. Treat provisioning as success only if echo successfully", true);
 
     ConfigKey<String> BaremetalIpmiLanInterface = new ConfigKey<>("Advanced", String.class, "baremetal.ipmi.lan.interface", "default",
-            "option specified in -I option of impitool. candidates are: open/bmc/lipmi/lan/lanplus/free/imb, see ipmitool man page for details. default value 'default' means using default option of ipmitool", true);
+            "option specified in -I option of ipmitool. candidates are: open/bmc/lipmi/lan/lanplus/free/imb, see ipmitool man page for details. default value 'default' means using default option of ipmitool", true);
 
-    ConfigKey<String> BaremetalIpmiRetryTimes = new ConfigKey<>("Advanced", String.class, "baremetal.ipmi.fail.retry", "5",
+    ConfigKey<Integer> BaremetalIpmiRetryTimes = new ConfigKey<>("Advanced", Integer.class, "baremetal.ipmi.fail.retry", "5",
             "ipmi interface will be temporary out of order after power operations(e.g. cycle, on), it leads following commands fail immediately. The value specifies retry times before accounting it as real failure", true);
 
     void notifyProvisionDone(BaremetalProvisionDoneNotificationCmd cmd);

plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BareMetalResourceBase.java

@@ -178,7 +178,7 @@ public boolean configure(String name, Map<String, Object> params) throws Configu
         }
 
         try {
-            ipmiRetryTimes = Integer.parseInt(BaremetalManager.BaremetalIpmiRetryTimes.value());
+            ipmiRetryTimes = BaremetalManager.BaremetalIpmiRetryTimes.value();
         } catch (Exception e) {
             logger.debug(e.getMessage(), e);
         }

plugins/network-elements/netscaler/src/main/java/com/cloud/network/element/NetscalerElement.java

@@ -946,8 +946,7 @@ public NetscalerLoadBalancerResponse createNetscalerLoadBalancerResponse(Externa
         response.setPrivateInterface(lbDetails.get("privateInterface"));
         response.setDeviceName(lbDeviceVO.getDeviceName());
         if (lbDeviceVO.getCapacity() == 0) {
-            long defaultLbCapacity = NumbersUtil
-                    .parseLong(DefaultExternalLoadBalancerCapacity.value(), 50);
+            long defaultLbCapacity = DefaultExternalLoadBalancerCapacity.value();
             response.setDeviceCapacity(defaultLbCapacity);
         } else {
             response.setDeviceCapacity(lbDeviceVO.getCapacity());

plugins/network-elements/palo-alto/src/main/java/com/cloud/network/element/PaloAltoExternalFirewallElement.java

@@ -73,7 +73,6 @@
 import com.cloud.network.rules.StaticNat;
 import com.cloud.offering.NetworkOffering;
 import com.cloud.offerings.dao.NetworkOfferingDao;
-import com.cloud.utils.NumbersUtil;
 import com.cloud.utils.db.EntityManager;
 import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.vm.NicProfile;
@@ -405,7 +404,7 @@ public PaloAltoFirewallResponse createPaloAltoFirewallResponse(ExternalFirewallD
         }
         response.setDeviceName(fwDeviceVO.getDeviceName());
         if (fwDeviceVO.getCapacity() == 0) {
-            long defaultFwCapacity = NumbersUtil.parseLong(DefaultExternalFirewallCapacity.value(), 50);
+            long defaultFwCapacity = DefaultExternalFirewallCapacity.value();
             response.setDeviceCapacity(defaultFwCapacity);
         } else {
             response.setDeviceCapacity(fwDeviceVO.getCapacity());

server/src/main/java/com/cloud/network/ExternalFirewallDeviceManager.java

@@ -36,7 +36,7 @@
 
 public interface ExternalFirewallDeviceManager extends Manager {
 
-    ConfigKey<String> DefaultExternalFirewallCapacity = new ConfigKey<>("Advanced", String.class, "external.firewall.default.capacity", "50",
+    ConfigKey<Integer> DefaultExternalFirewallCapacity = new ConfigKey<>("Advanced", Integer.class, "external.firewall.default.capacity", "50",
             "default number of networks permitted per external load firewall device", true);
 
     /**

server/src/main/java/com/cloud/network/ExternalFirewallDeviceManagerImpl.java

@@ -180,7 +180,7 @@ public abstract class ExternalFirewallDeviceManagerImpl extends AdapterBase impl
     public boolean configure(String name, Map<String, Object> params) throws ConfigurationException {
         super.configure(name, params);
         _resourceMgr.registerResourceStateAdapter(this.getClass().getSimpleName(), this);
-        _defaultFwCapacity = NumbersUtil.parseLong(DefaultExternalFirewallCapacity.value(), 50);
+        _defaultFwCapacity = DefaultExternalFirewallCapacity.value();
         return true;
     }
 

server/src/main/java/com/cloud/network/ExternalLoadBalancerDeviceManager.java

@@ -38,7 +38,7 @@ public interface ExternalLoadBalancerDeviceManager extends Manager {
 
     public static final int DEFAULT_LOAD_BALANCER_CAPACITY = 50;
 
-    ConfigKey<String> DefaultExternalLoadBalancerCapacity = new ConfigKey<>("Advanced", String.class, "external.lb.default.capacity", "50",
+    ConfigKey<Integer> DefaultExternalLoadBalancerCapacity = new ConfigKey<>("Advanced", Integer.class, "external.lb.default.capacity", "50",
             "default number of networks permitted per external load balancer device", true);
 
     /**

server/src/main/java/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java

@@ -1142,7 +1142,7 @@ public boolean manageGuestNetworkWithExternalLoadBalancer(boolean add, Network g
     @Override
     public boolean configure(String name, Map<String, Object> params) throws ConfigurationException {
         super.configure(name, params);
-        _defaultLbCapacity = NumbersUtil.parseLong(DefaultExternalLoadBalancerCapacity.value(), 50);
+        _defaultLbCapacity = DefaultExternalLoadBalancerCapacity.value();
         _resourceMgr.registerResourceStateAdapter(this.getClass().getSimpleName(), this);
         return true;
     }

server/src/main/java/com/cloud/server/ManagementServer.java

@@ -129,10 +129,10 @@ public interface ManagementServer extends ManagementService, PluggableService {
     ConfigKey<Integer> AlertPurgeDelay = new ConfigKey<>("Advanced", Integer.class, "alert.purge.delay", "0",
             "Alerts older than specified number days will be purged. Set this value to 0 to never delete alerts", true);
 
-    ConfigKey<String> ControlCidr = new ConfigKey<>("Advanced", String.class, "control.cidr", "169.254.0.0/16",
+    ConfigKey<String> ControlCidr = new ConfigKey<>("Advanced", String.class, "control.cidr", "169.254.0.0/16", //NOSONAR: RFC 3927 link-local block, not a real/routable address
             "Changes the cidr for the control network traffic.  Defaults to using link local.  Must be unique within pods", true);
 
-    ConfigKey<String> ControlGateway = new ConfigKey<>("Advanced", String.class, "control.gateway", "169.254.0.1",
+    ConfigKey<String> ControlGateway = new ConfigKey<>("Advanced", String.class, "control.gateway", "169.254.0.1", //NOSONAR: RFC 3927 link-local block, not a real/routable address
             "gateway for the control network traffic", true);
 
     ConfigKey<Integer> DetailBatchQuerySize = new ConfigKey<>("Advanced", Integer.class, "detail.batch.query.size", "2000",