Skip to content

Commit 1a19059

Browse files
Apply suggestions from code review
Address Wei's reviews Co-authored-by: Wei Zhou <[email protected]>
1 parent c6eeb75 commit 1a19059

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

engine/schema/templateConfig.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function getChecksum() {
6262
}
6363

6464
function createMetadataFile() {
65-
local fileData=$(cat $SOURCEFILE)
65+
local fileData=$(cat "$SOURCEFILE")
6666
echo -e "["default"]\nversion = $VERSION.${securityversion}\n" >> "$METADATAFILE"
6767
for template in "${templates[@]}"
6868
do
@@ -91,8 +91,8 @@ templates=( "kvm-x86_64:https://download.cloudstack.org/systemvm/${CS_VERSION}/s
9191
"ovm3:https://download.cloudstack.org/systemvm/$CS_VERSION/systemvmtemplate-$VERSION-x86_64-ovm.raw.bz2" )
9292

9393
PARENTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )/dist/systemvm-templates/"
94-
mkdir -p $PARENTPATH
94+
mkdir -p "$PARENTPATH"
9595
METADATAFILE="${PARENTPATH}metadata.ini"
9696
echo > "$METADATAFILE"
97-
SOURCEFILE=${PARENTPATH}'md5sum.txt'
97+
SOURCEFILE="${PARENTPATH}md5sum.txt"
9898
createMetadataFile

0 commit comments

Comments
 (0)