diff --git a/bookkeeper-server/pom.xml b/bookkeeper-server/pom.xml index 869d54597ad..1439466779d 100644 --- a/bookkeeper-server/pom.xml +++ b/bookkeeper-server/pom.xml @@ -102,11 +102,6 @@ circe-checksum ${project.version} - - org.apache.bookkeeper.stats - prometheus-metrics-provider - ${project.parent.version} - commons-cli commons-cli @@ -215,6 +210,12 @@ junit-jupiter-api test + + org.apache.bookkeeper.stats + prometheus-metrics-provider + ${project.parent.version} + test + org.apache.bookkeeper.stats otel-metrics-provider diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/MetricsService.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/MetricsService.java index 35cdb422bf3..d3d57f72fa4 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/MetricsService.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/MetricsService.java @@ -18,7 +18,6 @@ package org.apache.bookkeeper.server.http.service; -import io.prometheus.client.exporter.common.TextFormat; import java.io.IOException; import java.io.StringWriter; import org.apache.bookkeeper.conf.ServerConfiguration; @@ -36,6 +35,8 @@ */ public class MetricsService implements HttpEndpointService { + public static final String PROMETHEUS_CONTENT_TYPE_004 = "text/plain; version=0.0.4; charset=utf-8"; + private final ServerConfiguration conf; private final StatsProvider statsProvider; @@ -66,7 +67,7 @@ public HttpServiceResponse handle(HttpServiceRequest request) throws Exception { statsProvider.writeAllMetrics(writer); writer.flush(); response.setCode(StatusCode.OK); - response.setContentType(TextFormat.CONTENT_TYPE_004); + response.setContentType(PROMETHEUS_CONTENT_TYPE_004); response.setBody(writer.getBuffer().toString()); } catch (UnsupportedOperationException uoe) { response.setCode(StatusCode.INTERNAL_ERROR); diff --git a/bookkeeper-server/src/test/java/org/apache/bookkeeper/server/http/service/MetricsServiceTest.java b/bookkeeper-server/src/test/java/org/apache/bookkeeper/server/http/service/MetricsServiceTest.java index a8b28cd89ea..c46dfe29976 100644 --- a/bookkeeper-server/src/test/java/org/apache/bookkeeper/server/http/service/MetricsServiceTest.java +++ b/bookkeeper-server/src/test/java/org/apache/bookkeeper/server/http/service/MetricsServiceTest.java @@ -26,7 +26,6 @@ import static org.mockito.Mockito.doThrow; import static org.mockito.Mockito.mock; -import io.prometheus.client.exporter.common.TextFormat; import java.io.IOException; import java.io.Writer; import org.apache.bookkeeper.conf.ServerConfiguration; @@ -90,7 +89,7 @@ public void testWriteMetrics() throws Exception { HttpServiceResponse response = service.handle(request); assertEquals(StatusCode.OK.getValue(), response.getStatusCode()); - assertEquals(TextFormat.CONTENT_TYPE_004, response.getContentType()); + assertEquals(MetricsService.PROMETHEUS_CONTENT_TYPE_004, response.getContentType()); assertEquals(content, response.getBody()); }