Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Acero]Export SerialSequencingQueue and SequencingQueue to allow external node creation #45215

Closed
mroz45 opened this issue Jan 9, 2025 · 1 comment
Closed

[C++][Acero]Export SerialSequencingQueue and SequencingQueue to allow external node creation #45215

mroz45 opened this issue Jan 9, 2025 · 1 comment
Assignees
@mroz45
Labels
Component: C++ Type: enhancement
Milestone
20.0.0

Comments

@mroz45
Copy link
Contributor

mroz45 commented Jan 9, 2025 •
edited
Loading

Describe the enhancement requested

Currently, the SerialSequencingQueue and SequencingQueue classes are not part of the public API and are not exported. This limits the ability of users to extend the functionality of Apache Arrow by creating custom nodes that rely on this classes.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Jan 10, 2025
Merged
zanmato1984 pushed a commit that referenced this issue Jan 14, 2025
@mroz45
GH-45215:[C++][Acero]Export SequencingQueue and SerialSequencingQueue (…
0758845 
…#45221)

### Rationale for this change
SequencingQueue and SerialSequencingQueue are useful in creating custom ExecNodes. This patch allows linking to factory functions.

### What changes are included in this PR?

ARROW_ACERO_EXPORT classes

### Are there any user-facing changes?
Users can now directly instantiate and use the SequencingQueue and SerialSequencingQueue classes, enabling easier creation of custom ExecNode.

* GitHub Issue: #45215

Authored-by: kamilt <[email protected]>
Signed-off-by: Rossi Sun <[email protected]>
@zanmato1984 zanmato1984 added this to the 20.0.0 milestone Jan 14, 2025
@zanmato1984
Copy link
Contributor

Issue resolved by pull request 45221
#45221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mroz45 mroz45

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
20.0.0
Development

No branches or pull requests
2 participants
@zanmato1984 @mroz45