You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@chafey
It was suggested to me before by you, and perhaps others, that I remove the ojph_ prefix from the files. It makes everything shorter.
It is easy to do.
Are you still of this opinion?
I am not sure why a prefix is considered not scalable? We just have a prefix in the file names. A prefix is a best practice and it is used by many libraries including, for example, JPEG, TIFF, and PNG to name a few. Commonly headers are included by name, without including their directory, and the prefix avoids ambiguity. Headers are ideally portable and not tied to a directory structure. For example, the directory structure of headers in the OpenJPH source tree and install tree are different, and one may want to be able to build against one or the other. Or, they may want to vendor the headers in a different directory layout.
I would not mind keeping the prefix.
Perhaps, I can remove the prefix from internal files, and keep it for interface files (i.e., those included by other applications).
Activity
chafey commentedon Dec 21, 2022
Yes, this would be a good improvement.
thewtex commentedon Aug 8, 2023
Hi @aous72 @chafey ,
Thank you for your wonderful work 🙏
Can we please keep the ojph_ prefix to avoid ambiguity with similar files?
chafey commentedon Aug 8, 2023
aous72 commentedon Aug 8, 2023
Good to hear from you @thewtex, and thank you @chafey.
thewtex commentedon Aug 9, 2023
I am not sure why a prefix is considered not scalable? We just have a prefix in the file names. A prefix is a best practice and it is used by many libraries including, for example, JPEG, TIFF, and PNG to name a few. Commonly headers are included by name, without including their directory, and the prefix avoids ambiguity. Headers are ideally portable and not tied to a directory structure. For example, the directory structure of headers in the OpenJPH source tree and install tree are different, and one may want to be able to build against one or the other. Or, they may want to vendor the headers in a different directory layout.
aous72 commentedon Aug 11, 2023
I would not mind keeping the prefix.
Perhaps, I can remove the prefix from internal files, and keep it for interface files (i.e., those included by other applications).