Skip to content

Removing the ojph_ prefix. #98

@aous72

Description

@aous72
Owner

@chafey
It was suggested to me before by you, and perhaps others, that I remove the ojph_ prefix from the files. It makes everything shorter.
It is easy to do.
Are you still of this opinion?

Thank you.

Activity

chafey

chafey commented on Dec 21, 2022

@chafey
Contributor

Yes, this would be a good improvement.

thewtex

thewtex commented on Aug 8, 2023

@thewtex
Contributor

Hi @aous72 @chafey ,

Thank you for your wonderful work 🙏

Can we please keep the ojph_ prefix to avoid ambiguity with similar files?

chafey

chafey commented on Aug 8, 2023

@chafey
Contributor
aous72

aous72 commented on Aug 8, 2023

@aous72
OwnerAuthor

Good to hear from you @thewtex, and thank you @chafey.

thewtex

thewtex commented on Aug 9, 2023

@thewtex
Contributor

I am not sure why a prefix is considered not scalable? We just have a prefix in the file names. A prefix is a best practice and it is used by many libraries including, for example, JPEG, TIFF, and PNG to name a few. Commonly headers are included by name, without including their directory, and the prefix avoids ambiguity. Headers are ideally portable and not tied to a directory structure. For example, the directory structure of headers in the OpenJPH source tree and install tree are different, and one may want to be able to build against one or the other. Or, they may want to vendor the headers in a different directory layout.

aous72

aous72 commented on Aug 11, 2023

@aous72
OwnerAuthor

I would not mind keeping the prefix.
Perhaps, I can remove the prefix from internal files, and keep it for interface files (i.e., those included by other applications).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @thewtex@chafey@aous72

        Issue actions

          Removing the ojph_ prefix. · Issue #98 · aous72/OpenJPH