fix(ava-react/ntv): ntv phrase.origin tooltip can handle number string

Author: BBSQQ

packages/ava-react/src/NarrativeTextVis/chore/plugin/presets/createCompare.tsx

@@ -1,13 +1,13 @@
 import React, { ReactNode } from 'react';
 
-import { isNumber } from 'lodash';
+import { ValueAssessment, EntityMetaData } from '@antv/ava';
 
 import { ArrowDown, ArrowUp } from '../../../assets/icons';
 import { createEntityPhraseFactory } from '../createEntityPhraseFactory';
 import { NTV_PREFIX_CLS } from '../../../constants';
 import { getThemeColor } from '../../../theme';
+import { isNumberLike } from '../../../../utils';
 
-import { ValueAssessment, EntityMetaData } from '@antv/ava';
 import type { SpecificEntityPhraseDescriptor } from '../plugin-protocol.type';
 import type { ThemeType } from '../../../types';
 
@@ -37,7 +37,7 @@ const defaultDeltaValueDescriptor: SpecificEntityPhraseDescriptor = {
   classNames: (value, { assessment }) => [`${NTV_PREFIX_CLS}-value-${assessment}`],
   getText: getAssessmentText,
   tooltip: {
-    title: (value, metadata) => (isNumber(metadata.origin) ? `${metadata.origin}` : null),
+    title: (value, metadata) => (isNumberLike(metadata.origin) ? `${metadata.origin}` : null),
   },
 };
 
@@ -51,7 +51,7 @@ const defaultRatioValueDescriptor: SpecificEntityPhraseDescriptor = {
   classNames: (value, { assessment }) => [`${NTV_PREFIX_CLS}-value-${assessment}`],
   getText: getAssessmentText,
   tooltip: {
-    title: (value, metadata) => (isNumber(metadata.origin) ? `${metadata.origin}` : null),
+    title: (value, metadata) => (isNumberLike(metadata.origin) ? `${metadata.origin}` : null),
   },
 };
 

packages/ava-react/src/NarrativeTextVis/chore/plugin/presets/createContributeRatio.tsx

@@ -1,7 +1,6 @@
-import { isNumber } from 'lodash';
-
 import { createEntityPhraseFactory } from '../createEntityPhraseFactory';
 import { getThemeColor } from '../../../theme';
+import { isNumberLike } from '../../../../utils';
 
 import type { SpecificEntityPhraseDescriptor } from '../plugin-protocol.type';
 
@@ -10,7 +9,7 @@ const defaultContributeRatioDescriptor: SpecificEntityPhraseDescriptor = {
     color: (value, metadata, { theme }) => getThemeColor('colorConclusion', theme),
   },
   tooltip: {
-    title: (value, metadata) => (isNumber(metadata.origin) ? `${metadata.origin}` : null),
+    title: (value, metadata) => (isNumberLike(metadata.origin) ? `${metadata.origin}` : null),
   },
 };
 

packages/ava-react/src/NarrativeTextVis/chore/plugin/presets/createMetricValue.tsx

@@ -1,7 +1,6 @@
-import { isNumber } from 'lodash';
-
 import { createEntityPhraseFactory } from '../createEntityPhraseFactory';
 import { getThemeColor } from '../../../theme';
+import { isNumberLike } from '../../../../utils';
 
 import type { SpecificEntityPhraseDescriptor } from '../plugin-protocol.type';
 
@@ -10,7 +9,7 @@ const defaultMetricValueDescriptor: SpecificEntityPhraseDescriptor = {
     color: (value, metadata, { theme }) => getThemeColor('colorMetricValue', theme),
   },
   tooltip: {
-    title: (value, metadata) => (isNumber(metadata.origin) ? `${metadata.origin}` : null),
+    title: (value, metadata) => (isNumberLike(metadata.origin) ? `${metadata.origin}` : null),
   },
 };
 

packages/ava-react/src/NarrativeTextVis/chore/plugin/presets/createOtherMetricValue.tsx

@@ -1,7 +1,6 @@
-import { isNumber } from 'lodash';
-
 import { createEntityPhraseFactory } from '../createEntityPhraseFactory';
 import { getThemeColor } from '../../../theme';
+import { isNumberLike } from '../../../../utils';
 
 import type { SpecificEntityPhraseDescriptor } from '../plugin-protocol.type';
 
@@ -10,7 +9,7 @@ const defaultOtherMetricValueDescriptor: SpecificEntityPhraseDescriptor = {
     color: (value, metadata, { theme }) => getThemeColor('colorOtherValue', theme),
   },
   tooltip: {
-    title: (value, metadata) => (isNumber(metadata.origin) ? `${metadata.origin}` : null),
+    title: (value, metadata) => (isNumberLike(metadata.origin) ? `${metadata.origin}` : null),
   },
 };
 

packages/ava-react/src/NarrativeTextVis/chore/plugin/presets/createProportion.tsx

@@ -1,9 +1,10 @@
 import React from 'react';
 
-import { isNumber, isNaN } from 'lodash';
+import { isNaN } from 'lodash';
 
 import { ProportionChart } from '../../../line-charts';
 import { createEntityPhraseFactory } from '../createEntityPhraseFactory';
+import { isNumberLike } from '../../../../utils';
 
 import type { SpecificEntityPhraseDescriptor } from '../plugin-protocol.type';
 
@@ -23,7 +24,7 @@ const defaultProportionDescriptor: SpecificEntityPhraseDescriptor = {
     ),
   },
   tooltip: {
-    title: (value, metadata) => (isNumber(metadata.origin) ? `${metadata.origin}` : null),
+    title: (value, metadata) => (isNumberLike(metadata.origin) ? `${metadata.origin}` : null),
   },
 };
 

packages/ava-react/src/utils/index.ts

@@ -1,2 +1,3 @@
 export { getPrefixCls } from './getPrefixCls';
 export { classnames } from './classnames';
+export * from './isType';

packages/ava-react/src/utils/isType.ts

@@ -0,0 +1,6 @@
+import { toNumber, isNaN } from 'lodash';
+
+export function isNumberLike(val: unknown) {
+  const numVal = toNumber(val);
+  return !isNaN(numVal);
+}