Clean up ram_mux #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We apply implicit conditional I/O (inheritance of I/O predicates from branches) to simplify the logic of ram_mux. In addition, we note that in the current mux logic, we only ever have pending requests for the active channel, so we eliminate an unnecessary state element. While we're here, we also switch to using more explicit names.
Member
|
Thanks @ericastor! Appreciate the refactor, will have the team look at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We apply implicit conditional I/O (inheritance of I/O predicates from branches) to simplify the logic of ram_mux. In addition, we note that in the current mux logic, we only ever have pending requests for the active channel, so we eliminate an unnecessary state element.
While we're here, we also switch to using more explicit names.