Replies: 5 comments
-
I considered this as well, I think it could work, but I would say that it would be best to keep it to
I think those examples you mentioned there are appropriate at the
These are not just "confirmations that things are working as expected", so Another argument against changing to I believe we could also set up our own levels, but I think that would probably be more trouble than it's worth. |
Beta Was this translation helpful? Give feedback.
-
Regarding the deprecated warning message, I was thinking that the second message about how we convert the user input value can be moved to info level, sorry for not being clear. I think we can discuss further within team. |
Beta Was this translation helpful? Give feedback.
-
BTW after the discussion and to further clarify: switching the default output-to-console level to INFO and keeping DEBUG as the only level that is hidden by default, makes sense to me too, and seems to be the preferred option by the others. |
Beta Was this translation helpful? Give feedback.
-
For #2865 we have chosen it as warning on purpose because warning appears immediately after execution of required code, so user don't need to enable logging or set log level and look into log file. We can make "info" as the default logging level for PyFluent and if possible it should have same behavior like warning (it should appear immediately after execution of required code). |
Beta Was this translation helpful? Give feedback.
-
Hello @seanpearsonuk! If this issue needs to remain open, please comment below with If you want this repository to be excluded from this automated maintenance process, please let us know by filling in the opt-out request form. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
There are certain informational messages we want to show to PyFluent users (in connection of #2674 and #2865) which are currently categorized as warnings to display them by default. If we make
logging.INFO
as the default level, we will be able to show these message under the correct category. This will mean we need to move the currentlogging.INFO
messages which are not relevant to users tologging.DEBUG
level.Beta Was this translation helpful? Give feedback.
All reactions