fix: Block inactive object access via builtin classes. (#4729)

## Context
Previously, it was possible to access children of inactive objects via
builtin class instantiation.

## Change Summary
While instantiating builtin classes, use flobject's default `getattr` to
access child objects. That will throw `InactiveObjectError` from
appropriate place.
```
>>> pyfluent.solver.Viscous(solver)
D:\ANSYSDev\PyFluentDev\pyfluent\src\ansys\fluent\core\pyfluent_warnings.py:63: FluentDevVersionWarning: ⚠️ Warning: You are using PyFluent with an unreleased or development version of Fluent.
Compatibility is not guaranteed, and unexpected behavior may occur. Please use a released version of Fluent that is officially supported by this version of PyFluent.
  warnings.warn(
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
    import platform
  File "D:\ANSYSDev\PyFluentDev\pyfluent\src\ansys\fluent\core\generated\solver\settings_builtin.py", line 272, in __init__
    super().__init__(settings_source=settings_source)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\ANSYSDev\PyFluentDev\pyfluent\src\ansys\fluent\core\solver\settings_builtin_bases.py", line 93, in __init__
    _initialize_settings(self, {"settings_source": None}, settings_source, **kwargs)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\ANSYSDev\PyFluentDev\pyfluent\src\ansys\fluent\core\solver\settings_builtin_bases.py", line 85, in _initialize_settings
    instance.settings_source = settings_source
    ^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\ANSYSDev\PyFluentDev\pyfluent\src\ansys\fluent\core\solver\settings_builtin_bases.py", line 98, in __setattr__
    obj = _get_settings_obj(settings_root, self)
  File "D:\ANSYSDev\PyFluentDev\pyfluent\src\ansys\fluent\core\solver\settings_builtin_bases.py", line 74, in _get_settings_obj
    raise InactiveObjectError(builtin_cls_db_name) from None
ansys.fluent.core.solver.flobject.InactiveObjectError: 'Viscous' is currently inactive.
```
## Rationale
User should not be able to construct children of inactive builtin
objects. This conforms with the hierarchical settings API access.

## Impact
This will correct the builtin API behaviour.

---------

Co-authored-by: pyansys-ci-bot <[email protected]>

Author: mkundu1

doc/changelog.d/4729.fixed.md

@@ -0,0 +1 @@
+Block inactive object access via builtin classes.

src/ansys/fluent/core/solver/settings_builtin_bases.py

@@ -24,7 +24,11 @@
 
 from typing import Protocol, runtime_checkable
 
-from ansys.fluent.core.solver.flobject import NamedObject, SettingsBase
+from ansys.fluent.core.solver.flobject import (
+    InactiveObjectError,
+    NamedObject,
+    SettingsBase,
+)
 from ansys.fluent.core.solver.settings_builtin_data import DATA
 from ansys.fluent.core.utils.context_managers import _get_active_session
 from ansys.fluent.core.utils.fluent_version import FluentVersion
@@ -68,7 +72,10 @@ def _get_settings_obj(settings_root, builtin_settings_obj):
         found_path = path
     comps = found_path.split(".")
     for i, comp in enumerate(comps):
-        obj = SettingsBase.__getattribute__(obj, comp)  # bypass InactiveObjectError
+        try:
+            obj = getattr(obj, comp)
+        except InactiveObjectError:
+            raise InactiveObjectError(builtin_cls_db_name) from None
         if i < len(comps) - 1 and isinstance(obj, NamedObject):
             obj_name = getattr(builtin_settings_obj, comp)
             obj = obj[obj_name]

tests/test_builtin_settings.py

@@ -28,6 +28,7 @@
 import ansys.fluent.core as pyfluent
 from ansys.fluent.core.examples import download_file
 from ansys.fluent.core.solver import *  # noqa: F401, F403
+from ansys.fluent.core.solver.flobject import InactiveObjectError
 from ansys.fluent.core.utils.fluent_version import FluentVersion
 
 # flake8: noqa: F405
@@ -510,3 +511,11 @@ def test_context_manager_2(new_solver_session):
     with using(solver):
         read_case(file_name=import_filename)
         assert Viscous().model() == "k-omega"
+
+
+@pytest.mark.codegen_required
+def test_inactive_objects(new_solver_session):
+    solver = new_solver_session
+
+    with pytest.raises(InactiveObjectError):
+        pyfluent.solver.Viscous(solver)