From 98c7957364b1f76cdc9cabfdd2b96e75f66ef842 Mon Sep 17 00:00:00 2001 From: Alison Hart Date: Thu, 7 Dec 2023 14:14:16 -0500 Subject: [PATCH] Adding linter ignores for EDA linters (#249) Issue: AAH-2997 --- CHANGES/2997.bugfix | 1 + galaxy_importer/ansible_test/container/eda/tox.ini | 6 +++--- tests/integration/test_eda.py | 2 -- 3 files changed, 4 insertions(+), 5 deletions(-) create mode 100644 CHANGES/2997.bugfix diff --git a/CHANGES/2997.bugfix b/CHANGES/2997.bugfix new file mode 100644 index 00000000..ddabdf1a --- /dev/null +++ b/CHANGES/2997.bugfix @@ -0,0 +1 @@ +Ignore certain linter rules for ruff and pylint inside the EDA tox tests. \ No newline at end of file diff --git a/galaxy_importer/ansible_test/container/eda/tox.ini b/galaxy_importer/ansible_test/container/eda/tox.ini index 772d26de..4099f2a4 100644 --- a/galaxy_importer/ansible_test/container/eda/tox.ini +++ b/galaxy_importer/ansible_test/container/eda/tox.ini @@ -7,7 +7,7 @@ requires = [testenv:ruff] deps = ruff -commands = - ruff check --select ALL --ignore INP001 -q {posargs}/extensions/eda/plugins +commands = - ruff check --select ALL --ignore INP001,FA102,UP001,UP010,I001,FA100 -q {posargs}/extensions/eda/plugins [testenv:darglint] @@ -17,8 +17,8 @@ commands = - darglint -s numpy -z full {posargs}/extensions/eda/plugins [testenv:pylint-event-source] deps = pylint -commands = - pylint {posargs}/extensions/eda/plugins/event_source/*.py --output-format=parseable -sn --disable R0801 +commands = - pylint {posargs}/extensions/eda/plugins/event_source/*.py --output-format=parseable -sn --disable R0801,E0401,C0103,R0913 [testenv:pylint-event-filter] deps = pylint -commands = - pylint {posargs}/extensions/eda/plugins/event_filter/*.py --output-format=parseable -sn --disable R0801 \ No newline at end of file +commands = - pylint {posargs}/extensions/eda/plugins/event_filter/*.py --output-format=parseable -sn --disable R0801,E0401,C0103,R0913 \ No newline at end of file diff --git a/tests/integration/test_eda.py b/tests/integration/test_eda.py index 719392ca..43ffbdc9 100644 --- a/tests/integration/test_eda.py +++ b/tests/integration/test_eda.py @@ -38,9 +38,7 @@ def test_eda_import(workdir, local_image_config): assert "Running darglint on /extensions/eda/plugins..." in log assert "aws_sqs_queue.py:main:33: DAR101" in log assert "Running pylint on /extensions/eda/plugins/event_source..." in log - assert "aws_sqs_queue.py:29: [E0401" in log assert "Running pylint on /extensions/eda/plugins/event_filter..." in log - assert "insert_hosts_to_meta.py:31: [E0401" in log assert "EDA linting complete." in log assert "Removing temporary files, image and container" in log