Skip to content

Reviewing and merging dependency refreshes #2850

@oraNod

Description

@oraNod

Adding this as an issue to be sure we discuss it at the next DaWGs.

At the start of each week the pip-compile-* workflows run and bump dependencies which creates PRs such as: #2842

I've been reviewing and merging this as part of my Monday routine. Someone else will need to do this while I'm on PTO. I thought I'd share how I go about it.

When reviewing look at the files changed: https://github.com/ansible/ansible-documentation/pull/2842/files

The name of the requirements file, such as tests/static.txt, corresponds to a CI check. In this case the CI check would be nox / Run nox static session.

When looking for impact with the dependency bump, expand the step that runs the check and look for any issues. If you don't see any errors or messages, the dependency bump is most likely fine to merge.

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs_triageNeeds a first human triage before being processed.

    Type

    No type

    Projects

    Status

    🆕 Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions