From e626002260dea9663bc5ef839fd270f96ab4d18c Mon Sep 17 00:00:00 2001 From: rhymes Date: Thu, 9 May 2019 17:16:03 +0200 Subject: [PATCH] Add alternative texts to images (#2771) [ci skip] --- README.md | 32 +++----- .../initializers/initializeBaseUserData.js | 13 ++- .../initializers/initializeLiveArticle.js.erb | 7 +- .../utilities/buildArticleHTML.js.erb | 2 +- .../utilities/buildCommentHTML.js.erb | 2 +- app/helpers/application_helper.rb | 13 ++- .../__snapshots__/articleForm.test.jsx.snap | 4 + app/javascript/article-form/articleForm.jsx | 8 +- .../__snapshots__/article.test.jsx.snap | 3 + .../__snapshots__/userDetails.test.jsx.snap | 8 ++ app/javascript/chat/article.jsx | 4 +- app/javascript/chat/userDetails.jsx | 4 + app/javascript/src/Onboarding.jsx | 1 + .../__snapshots__/Onboarding.test.jsx.snap | 11 +++ .../github_tag/github_issue_tag.rb | 2 +- .../github_tag/github_readme_tag.rb | 2 +- app/liquid_tags/medium_tag.rb | 2 +- .../_article_followable_area.html.erb | 20 +++-- app/views/articles/_actions.html.erb | 4 +- app/views/articles/_markdown_form.html.erb | 4 +- .../articles/_podcast_episodes_feed.html.erb | 3 +- app/views/articles/_single_story.html.erb | 2 +- app/views/articles/_sticky_nav.html.erb | 8 +- app/views/articles/_v2_form.html.erb | 12 +-- app/views/articles/edit.html.erb | 2 +- app/views/articles/show.html.erb | 2 +- app/views/articles/tags/_sidebar.html.erb | 2 +- app/views/badges/show.html.erb | 2 +- app/views/comments/_comment_proper.html.erb | 2 +- app/views/dashboards/show.html.erb | 2 +- .../registrations/_registration_form.html.erb | 4 +- app/views/events/_event.html.erb | 8 +- app/views/events/index.html.erb | 2 +- .../fields/carrierwave_field/_form.html.erb | 2 +- .../fields/carrierwave_field/_index.html.erb | 2 +- .../fields/carrierwave_field/_show.html.erb | 2 +- .../internal/events/_event_form.html.erb | 2 +- app/views/internal/events/index.html.erb | 4 +- app/views/internal/users/_mentee_match.erb | 4 +- app/views/layouts/_signup_modal.html.erb | 8 +- app/views/layouts/_top_bar.html.erb | 8 +- app/views/liquids/_tweet.html.erb | 34 ++++---- ...new_membership_subscription_email.html.erb | 2 +- ...subscription_update_confirm_email.html.erb | 2 +- .../notify_mailer/new_badge_email.html.erb | 2 +- .../scholarship_awarded_email.html.erb | 2 +- app/views/moderations/mod.html.erb | 8 +- .../_aggregated_reactions.html.erb | 5 +- app/views/notifications/_comment.html.erb | 2 +- .../_notifications_list.html.erb | 4 +- app/views/notifications/_reaction.html.erb | 3 +- .../notifications/_signup_cta_test.html.erb | 2 +- .../notifications/_tagadjustment.html.erb | 2 +- .../shared/_comment_box.html.erb | 12 +-- .../_sidebar_additional.html.erb | 2 +- app/views/pages/about.html.erb | 34 +------- app/views/pages/badges.html.erb | 4 +- app/views/pages/generator.html.erb | 82 +++++++++---------- app/views/pages/information.html.erb | 10 +-- app/views/pages/live.html.erb | 4 +- app/views/pages/now.html.erb | 2 +- app/views/pages/rlyweb.html.erb | 80 +++++++++--------- app/views/pages/shecoded.html.erb | 10 +-- app/views/pages/sponsors.html.erb | 4 +- app/views/pages/workshops.html.erb | 2 +- .../podcast_episodes/_episodes_feed.html.erb | 3 +- app/views/podcast_episodes/_liquid.html.erb | 81 +++++++++--------- .../podcast_episodes/_podcast_bar.html.erb | 9 +- app/views/podcast_episodes/admin.html.erb | 3 +- app/views/podcast_episodes/edit.html.erb | 4 +- app/views/podcast_episodes/show.html.erb | 18 ++-- app/views/social_previews/article.html.erb | 2 +- app/views/social_previews/shecoded.html.erb | 2 +- app/views/social_previews/tag.html.erb | 2 +- app/views/social_previews/user.html.erb | 4 +- app/views/users/_account.html.erb | 8 +- app/views/users/_liquid.html.erb | 12 +-- app/views/users/_profile_header.html.erb | 24 +++--- app/views/users/_sidebar_additional.html.erb | 4 +- app/views/users/show.html.erb | 26 +++--- public/404.html | 14 +--- public/503.html | 6 +- spec/models/classified_listing_spec.rb | 4 +- .../github_liquid_tag_default.approved.html | 2 +- .../liquid_tweet_tag_spec.approved.html | 8 +- 85 files changed, 393 insertions(+), 386 deletions(-) diff --git a/README.md b/README.md index ba81acdf241f0..09ce45b1e3e09 100644 --- a/README.md +++ b/README.md @@ -1,35 +1,31 @@

- DEV + DEV

DEV Community πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

The Human Layer of the Stack
-
+

- ruby version + ruby version - rails version + rails version - Travis Status for thepracticaldev/dev.to + Travis Status for thepracticaldev/dev.to - + Code Climate maintainability - + Code Climate test coverage - Skylight badge + Skylight badge - CodeTriage badge + CodeTriage badge

@@ -242,14 +238,10 @@ Our version of the CLA was adapted from the Microsoft Contributor License Agreem Any questions, please refer to our [license FAQ](http://docs.dev.to/license-faq/) doc or email yo@dev.to -
+

- sloan -
+ Sloan, the sloth mascot +
Happy Coding ❀️

diff --git a/app/assets/javascripts/initializers/initializeBaseUserData.js b/app/assets/javascripts/initializers/initializeBaseUserData.js index d4de5bd17b3c4..cc3590c544414 100644 --- a/app/assets/javascripts/initializers/initializeBaseUserData.js +++ b/app/assets/javascripts/initializers/initializeBaseUserData.js @@ -57,7 +57,9 @@ function initializeUserSidebar(user) { function initializeUserProfileContent(user) { document.getElementById('sidebar-profile-pic').innerHTML = - ''; document.getElementById('sidebar-profile-name').innerHTML = filterXSS( @@ -73,12 +75,17 @@ function addRelevantButtonsToArticle(user) { var articleContainer = document.getElementById('article-show-container'); if (articleContainer) { if (parseInt(articleContainer.dataset.authorId) == user.id) { - var manageButtonHTML = 'MANAGE' + var manageButtonHTML = + 'MANAGE'; document.getElementById('action-space').innerHTML = 'EDIT' + - (JSON.parse(articleContainer.dataset.published) == true ? manageButtonHTML : "") + (JSON.parse(articleContainer.dataset.published) == true + ? manageButtonHTML + : ''); } else if (user.trusted) { document.getElementById('action-space').innerHTML = '#"+t+""}).join(" ") - return '<%=image_tag("/assets/cancel.svg")%>\ + return '<%= image_tag("/assets/cancel.svg", alt: "cancel live") %>\
\
Live Now
\
'+article.title+'
\ -
'+article.user.name+'
\ +
'+user.name+''+user.name+'
\
'+tagsHTML+'
\
' } @@ -73,4 +74,4 @@ function checkForOnPage(article){ } } }); -} \ No newline at end of file +} diff --git a/app/assets/javascripts/utilities/buildArticleHTML.js.erb b/app/assets/javascripts/utilities/buildArticleHTML.js.erb index 31ba2921cb480..8914444c6b422 100644 --- a/app/assets/javascripts/utilities/buildArticleHTML.js.erb +++ b/app/assets/javascripts/utilities/buildArticleHTML.js.erb @@ -104,7 +104,7 @@ function buildArticleHTML(article) { } var videoHTML = ''; if (article.cloudinary_video_url) { - videoHTML = '
" />'+article.video_duration_in_minutes+'
' + videoHTML = '
" alt="video camera">'+article.video_duration_in_minutes+'
' } var timeAgoInWords = ''; if (article.published_at_int) { diff --git a/app/assets/javascripts/utilities/buildCommentHTML.js.erb b/app/assets/javascripts/utilities/buildCommentHTML.js.erb index 5748ac56c2416..41518d9293522 100644 --- a/app/assets/javascripts/utilities/buildCommentHTML.js.erb +++ b/app/assets/javascripts/utilities/buildCommentHTML.js.erb @@ -38,7 +38,7 @@ function buildCommentHTML(comment) {
\
\ \ - \ + '+comment.user.username+'\ '+comment.user.name+'\ \ '+twitterIcon+'\ diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 9237b4f4c6ab6..0633a60109b44 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -69,7 +69,7 @@ def title_with_timeframe(page_title:, timeframe:, content_for: false) end def icon(name, pixels = "20") - image_tag icon_url(name), alt: name, class: "icon-img", height: pixels, width: pixels + image_tag(icon_url(name), alt: name, class: "icon-img", height: pixels, width: pixels) end def icon_url(name) @@ -183,12 +183,11 @@ def list_path end def logo_svg - logo = if ApplicationConfig["LOGO_SVG"].present? - ApplicationConfig["LOGO_SVG"].html_safe - else - inline_svg("devplain.svg", class: "logo", size: "20% * 20%") - end - logo + if ApplicationConfig["LOGO_SVG"].present? + ApplicationConfig["LOGO_SVG"].html_safe + else + inline_svg("devplain.svg", class: "logo", size: "20% * 20%", aria: true, title: "App logo") + end end def community_qualified_name diff --git a/app/javascript/article-form/__tests__/__snapshots__/articleForm.test.jsx.snap b/app/javascript/article-form/__tests__/__snapshots__/articleForm.test.jsx.snap index 1838d70361af3..30710be59e046 100644 --- a/app/javascript/article-form/__tests__/__snapshots__/articleForm.test.jsx.snap +++ b/app/javascript/article-form/__tests__/__snapshots__/articleForm.test.jsx.snap @@ -39,6 +39,7 @@ exports[` renders properly 1`] = ` onClick={[Function]} > upload images IMAGES @@ -48,6 +49,7 @@ exports[` renders properly 1`] = ` onClick={[Function]} > open overlay menu @@ -65,6 +67,7 @@ exports[` renders properly 1`] = ` onClick={[Function]} > upload images IMAGES @@ -74,6 +77,7 @@ exports[` renders properly 1`] = ` onClick={[Function]} > open overlay menu diff --git a/app/javascript/article-form/articleForm.jsx b/app/javascript/article-form/articleForm.jsx index b26ba288f813a..af93210410b13 100644 --- a/app/javascript/article-form/articleForm.jsx +++ b/app/javascript/article-form/articleForm.jsx @@ -321,7 +321,7 @@ export default class ArticleForm extends Component { className="articleform__detailsButton articleform__detailsButton--image" onClick={this.toggleImageManagement} > - + upload images {' '} IMAGES @@ -329,7 +329,7 @@ IMAGES className="articleform__detailsButton articleform__detailsButton--moreconfig" onClick={this.toggleMoreConfig} > - + open overlay menu
- + upload images {' '} IMAGES @@ -348,7 +348,7 @@ IMAGES className="articleform__detailsButton articleform__detailsButton--moreconfig articleform__detailsButton--bottom" onClick={this.toggleMoreConfig} > - + open overlay menu
); diff --git a/app/javascript/chat/__tests__/__snapshots__/article.test.jsx.snap b/app/javascript/chat/__tests__/__snapshots__/article.test.jsx.snap index 57ae568305790..cc9ed24fc3b17 100644 --- a/app/javascript/chat/__tests__/__snapshots__/article.test.jsx.snap +++ b/app/javascript/chat/__tests__/__snapshots__/article.test.jsx.snap @@ -86,6 +86,7 @@ exports[`
should load article 1`] = ` onClick={[Function]} > like reaction @@ -96,6 +97,7 @@ exports[`
should load article 1`] = ` onClick={[Function]} > unicorn reaction @@ -106,6 +108,7 @@ exports[`
should load article 1`] = ` onClick={[Function]} > readinglist reaction diff --git a/app/javascript/chat/__tests__/__snapshots__/userDetails.test.jsx.snap b/app/javascript/chat/__tests__/__snapshots__/userDetails.test.jsx.snap index fccddbc7a30a4..c3d1a942dc70f 100644 --- a/app/javascript/chat/__tests__/__snapshots__/userDetails.test.jsx.snap +++ b/app/javascript/chat/__tests__/__snapshots__/userDetails.test.jsx.snap @@ -3,6 +3,7 @@ exports[` for user1 should render and test snapshot 1`] = `
bojackhorseman profile image for user1 should render and test snapshot 1`] = ` target="_blank" > twitter logo for user1 should render and test snapshot 1`] = ` target="_blank" > github logo for user1 should render and test snapshot 1`] = ` target="_blank" > external link icon for user1 should render and test snapshot 1`] = ` exports[` for user2 should render and test snapshot 1`] = `
mrpeanutbutter profile image for user2 should render and test snapshot 1`] = ` target="_blank" > twitter logo for user2 should render and test snapshot 1`] = ` target="_blank" > github logo for user2 should render and test snapshot 1`] = ` target="_blank" > external link icon - + {`${curType[1]} ) }; @@ -173,7 +173,7 @@ export default class Article extends Component { {' '} - | + | {' '} {article.readable_publish_date} diff --git a/app/javascript/chat/userDetails.jsx b/app/javascript/chat/userDetails.jsx index 6b7675055df11..04ab14bf7e1e1 100644 --- a/app/javascript/chat/userDetails.jsx +++ b/app/javascript/chat/userDetails.jsx @@ -25,6 +25,7 @@ export default class UserDetails extends Component { twitter logo , ); @@ -35,6 +36,7 @@ export default class UserDetails extends Component { github logo , ); @@ -46,6 +48,7 @@ export default class UserDetails extends Component { className="external-link-img" src={websiteImage} style={{ width: '30px', margin: '5px 15px 15px 0px' }} + alt="external link icon" /> , ); @@ -63,6 +66,7 @@ export default class UserDetails extends Component {
{`${user.username}
{this.toggleOnboardingSlide()}
diff --git a/app/javascript/src/__tests__/__snapshots__/Onboarding.test.jsx.snap b/app/javascript/src/__tests__/__snapshots__/Onboarding.test.jsx.snap index 9271c077fb3d4..e0d8aa833b236 100644 --- a/app/javascript/src/__tests__/__snapshots__/Onboarding.test.jsx.snap +++ b/app/javascript/src/__tests__/__snapshots__/Onboarding.test.jsx.snap @@ -30,6 +30,7 @@ preact-render-spy (1 nodes) Sloan, the sloth mascot
@@ -146,6 +147,7 @@ preact-render-spy (1 nodes) Sloan, the sloth mascot
@@ -231,6 +233,7 @@ preact-render-spy (1 nodes) Sloan, the sloth mascot
@@ -374,6 +377,7 @@ preact-render-spy (1 nodes) Sloan, the sloth mascot
@@ -490,6 +494,7 @@ preact-render-spy (1 nodes) Sloan, the sloth mascot
@@ -640,6 +645,7 @@ preact-render-spy (1 nodes) Sloan, the sloth mascot
@@ -712,6 +718,7 @@ preact-render-spy (1 nodes) Sloan, the sloth mascot
@@ -862,6 +869,7 @@ preact-render-spy (1 nodes) Sloan, the sloth mascot
@@ -1005,6 +1013,7 @@ preact-render-spy (1 nodes) Sloan, the sloth mascot
@@ -1121,6 +1130,7 @@ preact-render-spy (1 nodes) Sloan, the sloth mascot
@@ -1264,6 +1274,7 @@ preact-render-spy (1 nodes) Sloan, the sloth mascot
diff --git a/app/liquid_tags/github_tag/github_issue_tag.rb b/app/liquid_tags/github_tag/github_issue_tag.rb index 743891f494ba3..fe1d47a516679 100644 --- a/app/liquid_tags/github_tag/github_issue_tag.rb +++ b/app/liquid_tags/github_tag/github_issue_tag.rb @@ -75,7 +75,7 @@ def generate_title "

" \ "" \ - "#{title} ##{number} " \ + "\"GitHub#{title} ##{number} " \ "" \ "

" end diff --git a/app/liquid_tags/github_tag/github_readme_tag.rb b/app/liquid_tags/github_tag/github_readme_tag.rb index 76ff78b4bebc4..6e310188d534a 100644 --- a/app/liquid_tags/github_tag/github_readme_tag.rb +++ b/app/liquid_tags/github_tag/github_readme_tag.rb @@ -12,7 +12,7 @@ def render

- #{@content.owner.login} / #{@content.name} + GitHub logo#{@content.owner.login} / #{@content.name}

#{@content.description}

diff --git a/app/liquid_tags/medium_tag.rb b/app/liquid_tags/medium_tag.rb index 4c94a9b7d93a2..826e73631fbb6 100644 --- a/app/liquid_tags/medium_tag.rb +++ b/app/liquid_tags/medium_tag.rb @@ -20,7 +20,7 @@ def render(_context)

#{response[:title]}

#{response[:author]}

- #{inline_svg('medium_icon.svg', size: '27px*27px')} Medium + #{inline_svg('medium_icon.svg', size: '27px*27px', aria: true, title: 'medium logo')} Medium
#{response[:reading_time]}
diff --git a/app/views/additional_content_boxes/_article_followable_area.html.erb b/app/views/additional_content_boxes/_article_followable_area.html.erb index e234c88892a10..258fb18956cb8 100644 --- a/app/views/additional_content_boxes/_article_followable_area.html.erb +++ b/app/views/additional_content_boxes/_article_followable_area.html.erb @@ -1,14 +1,17 @@ <% if followable.class.name == "Organization" && followable.nav_image.present? %>
- " /> + <%= followable.name %> profile image">
<% else %> @@ -18,6 +21,7 @@ data-details="<%= followable&.slug if classification == "boosted" %>__PROFILE"> <%= followable.name %> profile image__PROFILE" style="border: 4px solid <%= followable.bg_color_hex %>" />
diff --git a/app/views/articles/_actions.html.erb b/app/views/articles/_actions.html.erb index 3a30ccbe8f61f..969c6880bb144 100644 --- a/app/views/articles/_actions.html.erb +++ b/app/views/articles/_actions.html.erb @@ -13,7 +13,7 @@ - " /> + " alt="twitter logo"> DISCUSS @@ -24,7 +24,7 @@
diff --git a/app/views/articles/_markdown_form.html.erb b/app/views/articles/_markdown_form.html.erb index ec7c49ce9a9fa..a24addf26be03 100644 --- a/app/views/articles/_markdown_form.html.erb +++ b/app/views/articles/_markdown_form.html.erb @@ -98,7 +98,7 @@ <% if current_user.organization %>
- <%= current_user.organization.name %> + <%= current_user.organization.name %> profile image <%= current_user.organization.name %>
<% end %> @@ -106,7 +106,7 @@

- <%= @user.username %> profile + <%= @user.username %> profile image By <%= @user.name %> <% if @user.twitter_username.present? %> diff --git a/app/views/articles/_podcast_episodes_feed.html.erb b/app/views/articles/_podcast_episodes_feed.html.erb index b0c7448af6590..dd2352014b86b 100644 --- a/app/views/articles/_podcast_episodes_feed.html.erb +++ b/app/views/articles/_podcast_episodes_feed.html.erb @@ -10,7 +10,8 @@ quality: "auto", flags: "progressive", fetch_format: "auto", - sign_url: true) %> + sign_url: true, + alt: episode.title) %>

podcast<%= episode.title %>

diff --git a/app/views/articles/_single_story.html.erb b/app/views/articles/_single_story.html.erb index a6359592b9393..c687b7a41f8ec 100644 --- a/app/views/articles/_single_story.html.erb +++ b/app/views/articles/_single_story.html.erb @@ -2,7 +2,7 @@ <% if story.video.present? && story.video_thumbnail_url.present? %>
- " /><%= story.video_duration_in_minutes %>
+ " alt="video camera"><%= story.video_duration_in_minutes %>
<% end %> <% if story.cached_organization && !@organization_article_index %> diff --git a/app/views/articles/_sticky_nav.html.erb b/app/views/articles/_sticky_nav.html.erb index a1f44e1a6dd4d..ba9026b73001f 100644 --- a/app/views/articles/_sticky_nav.html.erb +++ b/app/views/articles/_sticky_nav.html.erb @@ -36,7 +36,7 @@
- + <%= @actor.name %> profile image
@@ -99,7 +99,7 @@
<% end %> - + <%= article.user.name %> profile image <%= article.title %>
<% article.decorate.cached_tag_list_array.each do |tag| %> @@ -115,11 +115,11 @@
<% if index == 0 %>
- " /> Trending on dev.to + " alt="Fire emoji"> Trending on dev.to
<% end %> - + <%= article.user.name %> profile image <%= article.title %>
<% article.decorate.cached_tag_list_array.each do |tag| %> diff --git a/app/views/articles/_v2_form.html.erb b/app/views/articles/_v2_form.html.erb index 60872269c27dc..989d765aa3f52 100644 --- a/app/views/articles/_v2_form.html.erb +++ b/app/views/articles/_v2_form.html.erb @@ -6,7 +6,7 @@
<% if @organization %>
- " /> + " alt="<%= @organization.name %> profile image"> <%= @organization.name %>
<% end %> <% if @article.main_image.present? %> -
+
article main image
<% end %>
@@ -22,18 +22,18 @@
<% if @article.published %>
diff --git a/app/views/articles/edit.html.erb b/app/views/articles/edit.html.erb index 33aa9b597fcd0..053e8e6ec2371 100644 --- a/app/views/articles/edit.html.erb +++ b/app/views/articles/edit.html.erb @@ -5,7 +5,7 @@ <% if @article.video_state == "PROGRESSING" %>

⏳ Video Transcoding In Progress ⏳

- + Bored kid incessantly tapping his fingers

You'll get an email when this process finishes. diff --git a/app/views/articles/show.html.erb b/app/views/articles/show.html.erb index 8e20d1b79d2a8..f79276c101c77 100644 --- a/app/views/articles/show.html.erb +++ b/app/views/articles/show.html.erb @@ -106,7 +106,7 @@ <% if @organization %>

- <%= @organization.name %> + <%= @organization.name %> profile image <%= @organization.name %>
<% end %> diff --git a/app/views/articles/tags/_sidebar.html.erb b/app/views/articles/tags/_sidebar.html.erb index 629d3f13d782e..59525814dca67 100644 --- a/app/views/articles/tags/_sidebar.html.erb +++ b/app/views/articles/tags/_sidebar.html.erb @@ -44,7 +44,7 @@ <% @moderators.each do |user| %>
- + <%= user.username %> profile image
<% end %> diff --git a/app/views/badges/show.html.erb b/app/views/badges/show.html.erb index 8110164e786ce..22a79cf474260 100644 --- a/app/views/badges/show.html.erb +++ b/app/views/badges/show.html.erb @@ -5,7 +5,7 @@

πŸ… <%= @badge.title %> Badge πŸ…

- + <%= @badge.title %> badge

<%= @badge.description %> diff --git a/app/views/comments/_comment_proper.html.erb b/app/views/comments/_comment_proper.html.erb index df1f614aa6c98..1f16e3e3b2781 100644 --- a/app/views/comments/_comment_proper.html.erb +++ b/app/views/comments/_comment_proper.html.erb @@ -20,7 +20,7 @@ quality: "auto", flags: "progressive", fetch_format: "auto", - sign_url: true), class: "sloan", alt: "sloth-mascot") %> + sign_url: true), class: "sloan", alt: "Sloan, the sloth mascot") %> Comment marked as low quality/non-constructive by the community View code of conduct

diff --git a/app/views/dashboards/show.html.erb b/app/views/dashboards/show.html.erb index cb3874cb4b2eb..9f72d06155196 100644 --- a/app/views/dashboards/show.html.erb +++ b/app/views/dashboards/show.html.erb @@ -46,7 +46,7 @@ quality: "auto", flags: "progressive", fetch_format: "auto", - sign_url: true), class: "sloan", alt: "sloth-mascot") %> + sign_url: true), class: "sloan", alt: "Sloan, the sloth mascot") %>

Also check out the Welcome Thread to introduce yourself!

diff --git a/app/views/devise/registrations/_registration_form.html.erb b/app/views/devise/registrations/_registration_form.html.erb index ba8f1dfaff1bf..26dc29b3fcf92 100644 --- a/app/views/devise/registrations/_registration_form.html.erb +++ b/app/views/devise/registrations/_registration_form.html.erb @@ -75,10 +75,10 @@ <% end %>
<%= ApplicationConfig["APP_DOMAIN"] %>/users/auth/twitter/callback" class="sign-up-link" data-no-instant> - <%= inline_svg("twitter-logo.svg", class: "icon-img") %> Sign In with Twitter + <%= inline_svg("twitter-logo.svg", class: "icon-img", aria: true, title: "twitter logo") %> Sign In with Twitter

We require social login to prevent abuse.

diff --git a/app/views/events/_event.html.erb b/app/views/events/_event.html.erb index 492b10d189666..05ecac9afe318 100644 --- a/app/views/events/_event.html.erb +++ b/app/views/events/_event.html.erb @@ -56,7 +56,7 @@
- + event image

<%= event.category %>: <%= event.title %>

@@ -80,10 +80,10 @@ <%= event.location_url %> 15 - <%= event.description_html.html_safe %> + <%= event.description_html.html_safe %> ------ - Link to attend - <%= event.location_url %> - + Link to attend - <%= event.location_url %> +
diff --git a/app/views/events/index.html.erb b/app/views/events/index.html.erb index 4703a279487c4..91d4914cbe0e7 100644 --- a/app/views/events/index.html.erb +++ b/app/views/events/index.html.erb @@ -24,7 +24,7 @@
- " style="height:200px;margin-top:30px;" /> + " style="height:200px;margin-top:30px;" alt="DEV membership logo">

UPCOMING
EVENTS

diff --git a/app/views/fields/carrierwave_field/_form.html.erb b/app/views/fields/carrierwave_field/_form.html.erb index 290d0e382a64b..30b524f5f9c6c 100644 --- a/app/views/fields/carrierwave_field/_form.html.erb +++ b/app/views/fields/carrierwave_field/_form.html.erb @@ -2,7 +2,7 @@ <%= f.label field.attribute %>
- <%= image_tag field.url, style: "background-color:#d9d9d9;max-width:100px" if field.url %> + <%= image_tag(field.url, style: "background-color:#d9d9d9;max-width:100px", alt: field.attribute.to_s.humanize) if field.url %>
<%= f.file_field field.attribute %>
diff --git a/app/views/fields/carrierwave_field/_index.html.erb b/app/views/fields/carrierwave_field/_index.html.erb index b6ba236fc2260..616bc89de8ace 100644 --- a/app/views/fields/carrierwave_field/_index.html.erb +++ b/app/views/fields/carrierwave_field/_index.html.erb @@ -1 +1 @@ -<%= image_tag field.url, style: "background-color:#d9d9d9" if field.url %> +<%= image_tag(field.url, style: "background-color:#d9d9d9", alt: field.attribute.to_s.humanize) if field.url %> diff --git a/app/views/fields/carrierwave_field/_show.html.erb b/app/views/fields/carrierwave_field/_show.html.erb index 15a40a9c3e86a..0523e5eaba25b 100644 --- a/app/views/fields/carrierwave_field/_show.html.erb +++ b/app/views/fields/carrierwave_field/_show.html.erb @@ -1 +1 @@ -<%= image_tag field.url, style: "background-color:#d9d9d9;max-width:400px" if field.url %> +<%= image_tag(field.url, style: "background-color:#d9d9d9;max-width:400px", alt: field.attribute.to_s.humanize) if field.url %> diff --git a/app/views/internal/events/_event_form.html.erb b/app/views/internal/events/_event_form.html.erb index 0798ef626cd41..c2bc422d5ee1a 100644 --- a/app/views/internal/events/_event_form.html.erb +++ b/app/views/internal/events/_event_form.html.erb @@ -1,7 +1,7 @@ <%= f.label :cover_image %>: <%= f.file_field :cover_image %>
- +event profile image
<%= f.label :profile_image %> (for live notification): <%= f.file_field :profile_image %> diff --git a/app/views/internal/events/index.html.erb b/app/views/internal/events/index.html.erb index 3828e27d832fd..07a6ff7d17b5f 100644 --- a/app/views/internal/events/index.html.erb +++ b/app/views/internal/events/index.html.erb @@ -17,7 +17,7 @@

Upcoming Events

<% @events.each do |event| %> <% if event.starts_at.future? %> - + event cover image
<%= form_for [:internal, event] do |f| %> <%= render "event_form", f: f, event: event %> @@ -29,7 +29,7 @@

Past Events

<% @events.each do |event| %> <% if !event.starts_at.future? %> - + event cover image
<%= form_for [:internal, event] do |f| %> <%= render "event_form", f: f, event: event %> diff --git a/app/views/internal/users/_mentee_match.erb b/app/views/internal/users/_mentee_match.erb index ed1fe04d7c6aa..3ec40efd757a3 100644 --- a/app/views/internal/users/_mentee_match.erb +++ b/app/views/internal/users/_mentee_match.erb @@ -2,7 +2,7 @@

Mentee Description

- + <%= @user.username %> profile image
@<%= @user.username %>
@@ -34,7 +34,7 @@ <% if !possible_mentor.banned_from_mentorship %>
- + <%= possible_mentor.username %> profile image
@<%= possible_mentor.username %>
diff --git a/app/views/layouts/_signup_modal.html.erb b/app/views/layouts/_signup_modal.html.erb index 040a9f15327f2..16dd2be00f7ec 100644 --- a/app/views/layouts/_signup_modal.html.erb +++ b/app/views/layouts/_signup_modal.html.erb @@ -1,7 +1,7 @@ <% end %> diff --git a/app/views/notifications/_tagadjustment.html.erb b/app/views/notifications/_tagadjustment.html.erb index 80d47558bb159..0a42957fd39a2 100644 --- a/app/views/notifications/_tagadjustment.html.erb +++ b/app/views/notifications/_tagadjustment.html.erb @@ -1,6 +1,6 @@
+ alt="Sloan, the sloth mascot">
<% data = notification.json_data %> diff --git a/app/views/notifications/shared/_comment_box.html.erb b/app/views/notifications/shared/_comment_box.html.erb index 047de7845aa9e..a35425ea731a1 100644 --- a/app/views/notifications/shared/_comment_box.html.erb +++ b/app/views/notifications/shared/_comment_box.html.erb @@ -6,17 +6,17 @@
<% if context == "moderation" && current_user.has_role?(:trusted) %> <% end %> <% cache "comment-box-comment-reply-#{@last_user_comment}-#{json_data['comment']['updated_at']}-#{json_data['comment']['id']}" do %> diff --git a/app/views/organizations/_sidebar_additional.html.erb b/app/views/organizations/_sidebar_additional.html.erb index f0607aa11f1e0..17852942f86d5 100644 --- a/app/views/organizations/_sidebar_additional.html.erb +++ b/app/views/organizations/_sidebar_additional.html.erb @@ -9,7 +9,7 @@ <% @organization.users.each do |user| %>
- + <%= user.username %> profile image
<% end %> diff --git a/app/views/pages/about.html.erb b/app/views/pages/about.html.erb index 1c28cdb1be5aa..6b0dde308da20 100644 --- a/app/views/pages/about.html.erb +++ b/app/views/pages/about.html.erb @@ -19,8 +19,6 @@ <% end %> - -
- " /> + " alt="clock">

diff --git a/app/views/pages/rlyweb.html.erb b/app/views/pages/rlyweb.html.erb index d56c9659b3934..af5ccefc00703 100644 --- a/app/views/pages/rlyweb.html.erb +++ b/app/views/pages/rlyweb.html.erb @@ -63,46 +63,46 @@

The animal images are from the USF ClipArt ETC project. They are used in this O RLY Cover Generator for the purposes of parody.

-
<%= image_tag "1.png" %>1
-
<%= image_tag "2.png" %>2
-
<%= image_tag "3.png" %>3
-
<%= image_tag "4.png" %>4
-
<%= image_tag "5.png" %>5
-
<%= image_tag "6.png" %>6
-
<%= image_tag "7.png" %>7
-
<%= image_tag "8.png" %>8
-
<%= image_tag "9.png" %>9
-
<%= image_tag "10.png" %>10
-
<%= image_tag "11.png" %>11
-
<%= image_tag "12.png" %>12
-
<%= image_tag "13.png" %>13
-
<%= image_tag "14.png" %>14
-
<%= image_tag "15.png" %>15
-
<%= image_tag "16.png" %>16
-
<%= image_tag "17.png" %>17
-
<%= image_tag "18.png" %>18
-
<%= image_tag "19.png" %>19
-
<%= image_tag "20.png" %>20
-
<%= image_tag "21.png" %>21
-
<%= image_tag "22.png" %>22
-
<%= image_tag "23.png" %>23
-
<%= image_tag "24.png" %>24
-
<%= image_tag "25.png" %>25
-
<%= image_tag "26.png" %>26
-
<%= image_tag "27.png" %>27
-
<%= image_tag "28.png" %>28
-
<%= image_tag "29.png" %>29
-
<%= image_tag "30.png" %>30
-
<%= image_tag "31.png" %>31
-
<%= image_tag "32.png" %>32
-
<%= image_tag "33.png" %>33
-
<%= image_tag "34.png" %>34
-
<%= image_tag "35.png" %>35
-
<%= image_tag "36.png" %>36
-
<%= image_tag "37.png" %>37
-
<%= image_tag "38.png" %>38
-
<%= image_tag "39.png" %>39
-
<%= image_tag "40.png" %>40
+
<%= image_tag("1.png", alt: "grizzly bear") %>1
+
<%= image_tag("2.png", alt: "cat") %>2
+
<%= image_tag("3.png", alt: "coyote") %>3
+
<%= image_tag("4.png", alt: "cow") %>4
+
<%= image_tag("5.png", alt: "horse") %>5
+
<%= image_tag("6.png", alt: "deer with antlers") %>6
+
<%= image_tag("7.png", alt: "baboon") %>7
+
<%= image_tag("8.png", alt: "wombat") %>8
+
<%= image_tag("9.png", alt: "platypus") %>9
+
<%= image_tag("10.png", alt: "bat") %>10
+
<%= image_tag("11.png", alt: "crested pelican") %>11
+
<%= image_tag("12.png", alt: "shoebill") %>12
+
<%= image_tag("13.png", alt: "wry-bill (bird)") %>13
+
<%= image_tag("14.png", alt: "raven") %>14
+
<%= image_tag("15.png", alt: "ostrich") %>15
+
<%= image_tag("16.png", alt: "chameleon") %>16
+
<%= image_tag("17.png", alt: "frog") %>17
+
<%= image_tag("18.png", alt: "mexican axolotl (salamander)") %>18
+
<%= image_tag("19.png", alt: "lizard") %>19
+
<%= image_tag("20.png", alt: "rattlesnake") %>20
+
<%= image_tag("21.png", alt: "catfish (sheatfish)") %>21
+
<%= image_tag("22.png", alt: "marbled angler fish") %>22
+
<%= image_tag("23.png", alt: "john dory fish") %>23
+
<%= image_tag("24.png", alt: "European lamprey or eel (stone sucker)") %>24
+
<%= image_tag("25.png", alt: "short sunfish") %>25
+
<%= image_tag("26.png", alt: "butterfly") %>26
+
<%= image_tag("27.png", alt: "moth") %>27
+
<%= image_tag("28.png", alt: "fly") %>28
+
<%= image_tag("29.png", alt: "dragonfly") %>29
+
<%= image_tag("30.png", alt: "stinkbug") %>30
+
<%= image_tag("31.png", alt: "spider") %>31
+
<%= image_tag("32.png", alt: "scorpion") %>32
+
<%= image_tag("33.png", alt: "crab") %>33
+
<%= image_tag("34.png", alt: "lobster") %>34
+
<%= image_tag("35.png", alt: "horseshoe crab") %>35
+
<%= image_tag("36.png", alt: "sea cucumber") %>36
+
<%= image_tag("37.png", alt: "abalone") %>37
+
<%= image_tag("38.png", alt: "jellyfish") %>38
+
<%= image_tag("39.png", alt: "coral") %>39
+
<%= image_tag("40.png", alt: "two mushrooms") %>40

Color Codes

0
diff --git a/app/views/pages/shecoded.html.erb b/app/views/pages/shecoded.html.erb index f924b172dcecb..8a5c221657c52 100644 --- a/app/views/pages/shecoded.html.erb +++ b/app/views/pages/shecoded.html.erb @@ -220,7 +220,7 @@

Nevertheless, She Coded

- " alt="shecoded logo" /> + " alt="shecoded logo">
It's International Women's Day!! @@ -257,7 +257,7 @@
<% @top_articles.each do |article| %> - + <%= article.user.name %> profile image

<%= article.title %>

@@ -265,13 +265,13 @@ <%= article.user.name %>
- #<%= (article.cached_tag_list_array & ["shecoded", "theycoded", "shecodedally"]).first %> + #<%= (article.cached_tag_list_array & %w[shecoded theycoded shecodedally]).first %>
<% end %> <% @articles.each do |article| %> - + <%= article.user.name %> profile image

<%= article.title %>

@@ -279,7 +279,7 @@ <%= article.user.name %>
- #<%= (article.cached_tag_list_array & ["shecoded", "theycoded", "shecodedally"]).first %> + #<%= (article.cached_tag_list_array & %w[shecoded theycoded shecodedally]).first %>
<% end %> diff --git a/app/views/pages/sponsors.html.erb b/app/views/pages/sponsors.html.erb index 6b68380c47d38..a800c00cc1947 100644 --- a/app/views/pages/sponsors.html.erb +++ b/app/views/pages/sponsors.html.erb @@ -27,7 +27,9 @@

for supporting our community

- ">Gold Sponsors"> + " alt="golden badge"> + Gold Sponsors + " alt="golden badge">

<% Organization.where(is_gold_sponsor: true).order("sponsorship_featured_number ASC").each do |organization| %> diff --git a/app/views/pages/workshops.html.erb b/app/views/pages/workshops.html.erb index 89773e3896eee..e98a272a433a7 100644 --- a/app/views/pages/workshops.html.erb +++ b/app/views/pages/workshops.html.erb @@ -13,7 +13,7 @@
- " style="height:200px;margin-top:30px;" /> + " style="height:200px;margin-top:30px;" alt="DEV membership logo">

DEV
WORKSHOPS

diff --git a/app/views/podcast_episodes/_episodes_feed.html.erb b/app/views/podcast_episodes/_episodes_feed.html.erb index b0c7448af6590..dd2352014b86b 100644 --- a/app/views/podcast_episodes/_episodes_feed.html.erb +++ b/app/views/podcast_episodes/_episodes_feed.html.erb @@ -10,7 +10,8 @@ quality: "auto", flags: "progressive", fetch_format: "auto", - sign_url: true) %> + sign_url: true, + alt: episode.title) %>

podcast<%= episode.title %>

diff --git a/app/views/podcast_episodes/_liquid.html.erb b/app/views/podcast_episodes/_liquid.html.erb index 6a4a81ba759a9..dc3c5c4df1d69 100644 --- a/app/views/podcast_episodes/_liquid.html.erb +++ b/app/views/podcast_episodes/_liquid.html.erb @@ -1,24 +1,29 @@ -
+<% image_url = cl_image_path(podcast.pattern_image_url || "https://i.imgur.com/fKYKgo4.png", + type: "fetch", quality: "auto", sign_url: true, + flags: "progressive", fetch_format: "jpg") %> + +

<%= episode.title %>

 <%= cl_image_tag(podcast.image_url, - type: 'fetch', - crop: 'fill', - quality: 'auto', - sign_url: true, - flags: 'progressive', - fetch_format: 'auto', - class: 'tinyimage') %> + type: "fetch", + crop: "fill", + quality: "auto", + sign_url: true, + flags: "progressive", + fetch_format: "auto", + class: "tinyimage", + alt: podcast.title) %>

<%= podcast.title %>
<% podcast_links.each do |name, source, img_src| %> <% if source %> - target="_blank" rel="noopener noreferrer"> - /> + + <%= name %> <%= name %> <% end %> @@ -26,54 +31,56 @@
- - - <%= cl_image_tag(podcast.image_url, - type: 'fetch', - crop: 'fill', - quality: 'auto', - sign_url: true, - flags: 'progressive', - fetch_format: 'auto', - class: 'podcastliquidtag__podcastimage', - id: "podcastimage-" + episode.slug) %> + play + pause + <%= cl_image_tag(podcast.image_url, + type: "fetch", + crop: "fill", + quality: "auto", + sign_url: true, + flags: "progressive", + fetch_format: "auto", + class: "podcastliquidtag__podcastimage", + id: "podcastimage-#{episode.slug}", + alt: podcast.title) %>