Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

calendar: doesn't support tabbing out of it when used standalone #9794

Closed
stefan-- opened this issue Oct 9, 2016 · 2 comments · Fixed by #12023
Closed

calendar: doesn't support tabbing out of it when used standalone #9794

stefan-- opened this issue Oct 9, 2016 · 2 comments · Fixed by #12023
Assignees
Labels
a11y This issue is related to accessibility has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed. type: bug
Milestone

Comments

@stefan--
Copy link

stefan-- commented Oct 9, 2016

Actual Behavior:

  • When using md-calendar the tabindex breaks
  • A user should be able to tab through the inputs next to a md-calendar

CodePen (or steps to reproduce the issue): *

Angular Versions: *

Additional Information:

  • Browser Type: * Chrome & Firefox
  • Browser Version: * Version 53.0.2785.116 (64-bit) & 47.0.1
  • OS: * Mac
  • Stack Traces: none

Shortcut to create a new CodePen Demo.
Note: * indicates required information. Without this information, your issue may be auto-closed.

Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.

@crisbeto
Copy link
Member

crisbeto commented Oct 9, 2016

This should be fixed when either #9746 or #9641 get merged.

@crisbeto crisbeto added type: bug has: Pull Request A PR has been created to address this issue labels Oct 9, 2016
@crisbeto crisbeto self-assigned this Oct 9, 2016
@ThomasBurleson ThomasBurleson modified the milestone: 1.1.2 Oct 11, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.2, 1.1.4 Feb 4, 2017
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.4, 1.1.5 May 7, 2017
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.5, 1.1.6 Sep 5, 2017
@Splaktar Splaktar modified the milestones: 1.1.6, 1.1.7 Jan 17, 2018
@Splaktar Splaktar assigned Splaktar and unassigned ThomasBurleson Feb 7, 2018
@Splaktar Splaktar added a11y This issue is related to accessibility P2: required Issues that must be fixed. labels Feb 7, 2018
@Splaktar
Copy link
Contributor

Splaktar commented Feb 7, 2018

#9746 was merged into 1.1.2, but I tested with the jsfiddle above (which uses master) on 1.1.6 and the issue still occurs.

@Splaktar Splaktar modified the milestones: 1.1.7, 1.2.0 Feb 7, 2018
@Splaktar Splaktar changed the title md-calendar tabindex calendar: doesn't support tabbing out of it when used standalone Jul 1, 2020
@Splaktar Splaktar modified the milestones: 1.2.0, 1.2.1 Jul 1, 2020
@Splaktar Splaktar added has: Pull Request A PR has been created to address this issue and removed has: Pull Request A PR has been created to address this issue labels Sep 23, 2020
Splaktar added a commit that referenced this issue Sep 23, 2020
- using the `md-calendar` outside of the `md-datepicker` no longer
  breaks the page's tab order
- change one access of the global `document` to use `$document`
- improve Closure types
- update JSDoc for `CalendarCtrl.handleKeyEvent()`

Fixes #9794
Splaktar added a commit that referenced this issue Sep 23, 2020
- using the `md-calendar` outside of the `md-datepicker` no longer
  breaks the page's tab order
- change one access of the global `document` to use `$document`
- improve Closure types
- update JSDoc for `CalendarCtrl.handleKeyEvent()`

Fixes #9794
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed. type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants