This repository was archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
dialog: theme not inheriting properly when changing themesΒ #11229
Copy link
Copy link
Open
Labels
P3: importantImportant issues that really should be fixed when possible.Important issues that really should be fixed when possible.type: docsui: theme
Milestone
Description
Bug, feature request, or proposal:
Bug
What is the expected behavior?
The dialog will take on the theme that is set on its parent element (or somewhere in the ascendants).
What is the current behavior?
If changing the theme, the dialog still uses the previous theme.
CodePen and steps to reproduce the issue:
CodePen Demo which shows your issue: https://codepen.io/anon/pen/WzmmKx
Detailed Reproduction Steps:
- set a theme
- open dialog WITHOUT targetEvent set with an md-primary button and view theme
- switch theme using theme provider/service
- open dialog and see that theme did not update
What is the use-case or motivation for changing an existing behavior?
It essentially renders theme changing useless since the interim elements don't respect the change.
Which versions of AngularJS, Material, OS, and browsers are affected?
AngularJS Material >= 1.1.2
AngularJS >= 1.6.0
Is there anything else we should know? Stack Traces, Screenshots, etc.
Likely something in the following changes that broke it: https://github.com/angular/material/pull/9762/files#diff-58cbee594b2fabf2c78b6d283750e535R806
codymikol, lenonestrella and motabass
Metadata
Metadata
Assignees
Labels
P3: importantImportant issues that really should be fixed when possible.Important issues that really should be fixed when possible.type: docsui: theme