Skip to content

Commit eac1825

Browse files
filipesilvahansl
authored andcommitted
test: remove redundant check in rebuild-error
There's no need to check for the error test since `waitForAnyProcessOutputToMatch` is already matching successes only. Checking both was causing flakes when the webpack triggered multiple initial builds.
1 parent 131b1d0 commit eac1825

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

tests/e2e/tests/build/rebuild-error.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import {getGlobalVariable} from '../../utils/env';
99

1010
const failedRe = /webpack: Failed to compile/;
1111
const successRe = /webpack: Compiled successfully/;
12-
const errorRe = /ERROR in/;
1312

1413
export default function() {
1514
if (process.platform.startsWith('win')) {
@@ -30,12 +29,6 @@ export default function() {
3029
waitForAnyProcessOutputToMatch(successRe, 20000),
3130
replaceInFile('src/app/app.component.ts', ']]]]]', '')
3231
]))
33-
.then((results) => {
34-
const stderr = results[0].stderr;
35-
if (errorRe.test(stderr)) {
36-
throw new Error('Expected no error but an error was shown.');
37-
}
38-
})
3932
.then(() => killAllProcesses(), (err: any) => {
4033
killAllProcesses();
4134
throw err;

0 commit comments

Comments
 (0)