refactor(@angular/cli): update yarn modern dependency parsing

This commit updates the dependency discovery logic for Yarn Modern (Berry) to use the `yarn info --name-only --json` command, as the `list` command is not available in newer versions of Yarn.

Author: clydin

packages/angular/cli/src/package-managers/package-manager-descriptor.ts

@@ -167,7 +167,7 @@ export const SUPPORTED_PACKAGE_MANAGERS = {
     ignoreScriptsFlag: '--ignore-scripts',
     getRegistryOptions: (registry: string) => ({ env: { NPM_CONFIG_REGISTRY: registry } }),
     versionCommand: ['--version'],
-    listDependenciesCommand: ['list', '--depth=0', '--json', '--recursive=false'],
+    listDependenciesCommand: ['info', '--name-only', '--json'],
     getManifestCommand: ['npm', 'info', '--json'],
     viewCommandFieldArgFormatter: (fields) => ['--fields', fields.join(',')],
     outputParsers: {

packages/angular/cli/src/package-managers/parsers.ts

@@ -170,74 +170,6 @@ export function parseYarnClassicDependencies(
   return dependencies;
 }
 
-/**
- * Parses the output of `yarn list` (modern).
- *
- * The expected JSON structure is a single object.
- * Yarn modern does not provide a path, so the `path` property will be `undefined`.
- *
- * ```json
- * {
- *   "trees": [
- *     { "name": "@angular/cli@18.0.0", "children": [] }
- *   ]
- * }
- * ```
- *
- * @param stdout The standard output of the command.
- * @param logger An optional logger instance.
- * @returns A map of package names to their installed package details.
- */
-export function parseYarnModernDependencies(
-  stdout: string,
-  logger?: Logger,
-): Map<string, InstalledPackage> {
-  logger?.debug(`Parsing yarn modern dependency list...`);
-  logStdout(stdout, logger);
-
-  const dependencies = new Map<string, InstalledPackage>();
-  if (!stdout) {
-    logger?.debug('  stdout is empty. No dependencies found.');
-
-    return dependencies;
-  }
-
-  // Modern yarn `list` command outputs a single JSON object with a `trees` property.
-  // Each line is not a separate JSON object.
-  try {
-    const data = JSON.parse(stdout);
-    for (const info of data.trees) {
-      const name = info.name.split('@')[0];
-      const version = info.name.split('@').pop();
-      dependencies.set(name, {
-        name,
-        version,
-      });
-    }
-  } catch (e) {
-    logger?.debug(
-      `  Failed to parse as single JSON object: ${e}. Falling back to line-by-line parsing.`,
-    );
-    // Fallback for older versions of yarn berry that might still output json lines
-    for (const json of parseJsonLines(stdout, logger)) {
-      if (json.type === 'tree' && json.data?.trees) {
-        for (const info of json.data.trees) {
-          const name = info.name.split('@')[0];
-          const version = info.name.split('@').pop();
-          dependencies.set(name, {
-            name,
-            version,
-          });
-        }
-      }
-    }
-  }
-
-  logger?.debug(`  Found ${dependencies.size} dependencies.`);
-
-  return dependencies;
-}
-
 /**
  * Parses the output of `npm view` or a compatible command to get a package manifest.
  * @param stdout The standard output of the command.
@@ -573,3 +505,59 @@ export function parseBunDependencies(
 
   return dependencies;
 }
+
+/**
+ * Parses the output of `yarn info --name-only --json`.
+ *
+ * The expected output is a JSON stream (JSONL) of strings.
+ * Each string represents a package locator.
+ *
+ * ```
+ * "karma@npm:6.4.4"
+ * "@angular/core@npm:20.3.15"
+ * ```
+ *
+ * @param stdout The standard output of the command.
+ * @param logger An optional logger instance.
+ * @returns A map of package names to their installed package details.
+ */
+export function parseYarnModernDependencies(
+  stdout: string,
+  logger?: Logger,
+): Map<string, InstalledPackage> {
+  logger?.debug('Parsing Yarn Berry dependency list...');
+  logStdout(stdout, logger);
+
+  const dependencies = new Map<string, InstalledPackage>();
+  if (!stdout) {
+    return dependencies;
+  }
+
+  for (const json of parseJsonLines(stdout, logger)) {
+    if (typeof json === 'string') {
+      const match = json.match(/^(@?[^@]+)@(.+)$/);
+      if (match) {
+        const name = match[1];
+        let version = match[2];
+
+        // Handle "npm:" prefix
+        if (version.startsWith('npm:')) {
+          version = version.slice(4);
+        }
+
+        // Handle complex locators with embedded version metadata (e.g., "patch:...", "virtual:...")
+        // Yarn Berry often appends metadata like "::version=x.y.z"
+        const versionParamMatch = version.match(/::version=([^&]+)/);
+        if (versionParamMatch) {
+          version = versionParamMatch[1];
+        }
+
+        dependencies.set(name, { name, version });
+      }
+    }
+  }
+
+  logger?.debug(`  Found ${dependencies.size} dependencies.`);
+
+  return dependencies;
+}

packages/angular/cli/src/package-managers/parsers_spec.ts

@@ -6,7 +6,12 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import { parseBunDependencies, parseNpmLikeError, parseYarnClassicError } from './parsers';
+import {
+  parseBunDependencies,
+  parseNpmLikeError,
+  parseYarnClassicError,
+  parseYarnModernDependencies,
+} from './parsers';
 
 describe('parsers', () => {
   describe('parseNpmLikeError', () => {
@@ -146,4 +151,38 @@ project node_modules
       expect(parseBunDependencies(stdout).size).toBe(0);
     });
   });
+
+  describe('parseYarnModernDependencies', () => {
+    it('should parse yarn info --name-only --json output', () => {
+      const stdout = `
+"karma@npm:6.4.4"
+"rxjs@npm:7.8.2"
+"tslib@npm:2.8.1"
+"typescript@patch:typescript@npm%3A5.9.3#optional!builtin<compat/typescript>::version=5.9.3&hash=5786d5"
+`.trim();
+
+      const deps = parseYarnModernDependencies(stdout);
+      expect(deps.size).toBe(4);
+      expect(deps.get('karma')).toEqual({ name: 'karma', version: '6.4.4' });
+      expect(deps.get('rxjs')).toEqual({ name: 'rxjs', version: '7.8.2' });
+      expect(deps.get('tslib')).toEqual({ name: 'tslib', version: '2.8.1' });
+      expect(deps.get('typescript')).toEqual({
+        name: 'typescript',
+        version: '5.9.3',
+      });
+    });
+
+    it('should handle scoped packages', () => {
+      const stdout = '"@angular/core@npm:20.3.15"';
+      const deps = parseYarnModernDependencies(stdout);
+      expect(deps.get('@angular/core')).toEqual({
+        name: '@angular/core',
+        version: '20.3.15',
+      });
+    });
+
+    it('should return empty map for empty stdout', () => {
+      expect(parseYarnModernDependencies('').size).toBe(0);
+    });
+  });
 });