Skip to content

Commit 7fed4cf

Browse files
clydinalan-agius4
authored andcommitted
style(@angular-devkit/build-angular): remove unneeded no-implicit-dependencies rule disabling
1 parent ac9db98 commit 7fed4cf

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

packages/angular_devkit/build_angular/src/utils/load-translations.ts

+5-7
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,9 @@ import * as fs from 'fs';
1111
export type TranslationLoader = (
1212
path: string,
1313
) => {
14-
// tslint:disable-next-line: no-implicit-dependencies
1514
translations: Record<string, import('@angular/localize').ɵParsedTranslation>;
1615
format: string;
1716
locale?: string;
18-
// tslint:disable-next-line: no-implicit-dependencies
1917
diagnostics: import('@angular/localize/src/tools/src/diagnostics').Diagnostics;
2018
integrity: string;
2119
};
@@ -63,26 +61,26 @@ export async function createTranslationLoader(): Promise<TranslationLoader> {
6361

6462
async function importParsers() {
6563
try {
66-
// tslint:disable-next-line: no-implicit-dependencies
64+
6765
const localizeDiag = await import('@angular/localize/src/tools/src/diagnostics');
6866
const diagnostics = new localizeDiag.Diagnostics();
6967

7068
const parsers = {
7169
json: new (await import(
72-
// tslint:disable-next-line:trailing-comma no-implicit-dependencies
70+
// tslint:disable-next-line:trailing-comma
7371
'@angular/localize/src/tools/src/translate/translation_files/translation_parsers/simple_json_translation_parser'
7472
)).SimpleJsonTranslationParser(),
7573
xlf: new (await import(
76-
// tslint:disable-next-line:trailing-comma no-implicit-dependencies
74+
// tslint:disable-next-line:trailing-comma
7775
'@angular/localize/src/tools/src/translate/translation_files/translation_parsers/xliff1_translation_parser'
7876
)).Xliff1TranslationParser(),
7977
xlf2: new (await import(
80-
// tslint:disable-next-line:trailing-comma no-implicit-dependencies
78+
// tslint:disable-next-line:trailing-comma
8179
'@angular/localize/src/tools/src/translate/translation_files/translation_parsers/xliff2_translation_parser'
8280
)).Xliff2TranslationParser(),
8381
// The name ('xmb') needs to match the AOT compiler option
8482
xmb: new (await import(
85-
// tslint:disable-next-line:trailing-comma no-implicit-dependencies
83+
// tslint:disable-next-line:trailing-comma
8684
'@angular/localize/src/tools/src/translate/translation_files/translation_parsers/xtb_translation_parser'
8785
)).XtbTranslationParser(),
8886
};

packages/angular_devkit/build_angular/src/utils/process-bundle.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@ export async function createI18nPlugins(
560560
const diagnostics = new localizeDiag.Diagnostics();
561561

562562
const es2015 = await import(
563-
// tslint:disable-next-line: trailing-comma no-implicit-dependencies
563+
// tslint:disable-next-line: trailing-comma
564564
'@angular/localize/src/tools/src/translate/source_files/es2015_translate_plugin'
565565
);
566566
plugins.push(
@@ -571,7 +571,7 @@ export async function createI18nPlugins(
571571
);
572572

573573
const es5 = await import(
574-
// tslint:disable-next-line: trailing-comma no-implicit-dependencies
574+
// tslint:disable-next-line: trailing-comma
575575
'@angular/localize/src/tools/src/translate/source_files/es5_translate_plugin'
576576
);
577577
plugins.push(
@@ -582,7 +582,7 @@ export async function createI18nPlugins(
582582
);
583583

584584
const inlineLocale = await import(
585-
// tslint:disable-next-line: trailing-comma no-implicit-dependencies
585+
// tslint:disable-next-line: trailing-comma
586586
'@angular/localize/src/tools/src/translate/source_files/locale_plugin'
587587
);
588588
plugins.push(inlineLocale.makeLocalePlugin(locale));

0 commit comments

Comments
 (0)