build: update puppeteer to v24.37.5

Author: clydin

modules/testing/builder/projects/hello-world-app/karma.conf.js

@@ -10,7 +10,10 @@
 // https://karma-runner.github.io/1.0/config/configuration-file.html
 
 const path = require('path');
-process.env.CHROME_BIN = require('puppeteer').executablePath();
+
+// Resolve from relative paths to absolute paths within the bazel runfiles tree
+// so subprocesses spawned in a different working directory can still find them.
+process.env.CHROME_BIN = process.env.CHROME_BIN ? path.resolve(path.join(process.cwd(), '..', '..', '..'), process.env.CHROME_BIN) : require('puppeteer').executablePath();
 
 module.exports = function(config) {
   config.set({

package.json

@@ -118,7 +118,7 @@
     "lodash": "^4.17.21",
     "magic-string": "0.30.21",
     "prettier": "^3.0.0",
-    "puppeteer": "18.2.1",
+    "puppeteer": "24.37.5",
     "quicktype-core": "23.2.6",
     "rollup": "4.59.0",
     "rollup-license-plugin": "~3.1.0",
@@ -144,7 +144,6 @@
   },
   "pnpm": {
     "onlyBuiltDependencies": [
-      "puppeteer",
       "webdriver-manager"
     ],
     "overrides": {

packages/angular/build/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts

@@ -153,7 +153,7 @@ describeServeBuilder(executeDevServer, DEV_SERVER_BUILDER_INFO, (harness, setupT
         // See: https://github.com/angular/angular-cli/pull/17624
         // eslint-disable-next-line max-len
         // executablePath: '/Users/<USERNAME>/git/angular-cli/node_modules/puppeteer/.local-chromium/mac-818858/chrome-mac/Chromium.app/Contents/MacOS/Chromium',
-        ignoreHTTPSErrors: true,
+        acceptInsecureCerts: true,
         args: ['--no-sandbox', '--disable-gpu'],
       });
     });

packages/angular_devkit/build_angular/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts

@@ -161,7 +161,7 @@ describeServeBuilder(
             // See: https://github.com/angular/angular-cli/pull/17624
             // eslint-disable-next-line max-len
             // executablePath: '/Users/<USERNAME>/git/angular-cli/node_modules/puppeteer/.local-chromium/mac-818858/chrome-mac/Chromium.app/Contents/MacOS/Chromium',
-            ignoreHTTPSErrors: true,
+            acceptInsecureCerts: true,
             args: ['--no-sandbox', '--disable-gpu'],
           });
         });

pnpm-lock.yaml

@@ -97,7 +97,7 @@ export default async function () {
     checkFn: async (page) => {
       const warnMessages: string[] = [];
       page.on('console', (msg) => {
-        if (msg.type() === 'warning') {
+        if (msg.type() === 'warn') {
           warnMessages.push(msg.text());
         }
       });

tests/e2e/tests/build/auto-csp.ts

@@ -53,7 +53,7 @@ export async function executeBrowserTest(options: BrowserTestOptions = {}) {
         }
       });
       page.on('pageerror', (err) => {
-        errors.push(err.toString());
+        errors.push(`${err}`);
       });
 
       await page.goto(url);

tests/e2e/utils/puppeteer.ts

@@ -65,9 +65,22 @@ def jasmine_test(data = [], args = [], **kwargs):
     # we change the `chdir` below to the package directory.
     relative_to_root = "/".join([".."] * len(native.package_name().split("/")))
 
+    # Chromium browser toolchain
+    env = kwargs.pop("env", {})
+    env.update({
+        "CHROME_BIN": "$(CHROME-HEADLESS-SHELL)",
+        "CHROME_PATH": "$(CHROME-HEADLESS-SHELL)",
+        "CHROMEDRIVER_BIN": "$(CHROMEDRIVER)",
+    })
+    toolchains = kwargs.pop("toolchains", [])
+    toolchains = toolchains + ["@rules_browsers//browsers/chromium:toolchain_alias"]
+    data = data + ["@rules_browsers//browsers/chromium"]
+
     _jasmine_test(
         node_modules = "//:node_modules",
         chdir = native.package_name(),
+        env = env,
+        toolchains = toolchains,
         args = [
             "--require=%s/node_modules/source-map-support/register.js" % relative_to_root,
             # Escape so that the `js_binary` launcher triggers Bash expansion.