Skip to content

Commit a8b909d

Browse files
committed
Merge pull request #4688 from imbalind/issue4687
(fix): Fix #4687 - Memory leaks - grid object not getting destroyed
2 parents e0cf819 + b031a3d commit a8b909d

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/js/core/directives/ui-grid-menu.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ function ($compile, $timeout, $window, $document, gridUtil, uiGridConstants, i18
4343
templateUrl: 'ui-grid/uiGridMenu',
4444
replace: false,
4545
link: function ($scope, $elm, $attrs, uiGridCtrl) {
46-
var self = this;
4746
var menuMid;
4847
var $animate;
4948

@@ -52,7 +51,7 @@ function ($compile, $timeout, $window, $document, gridUtil, uiGridConstants, i18
5251
};
5352

5453
// *** Show/Hide functions ******
55-
self.showMenu = $scope.showMenu = function(event, args) {
54+
$scope.showMenu = function(event, args) {
5655
if ( !$scope.shown ){
5756

5857
/*
@@ -96,7 +95,7 @@ function ($compile, $timeout, $window, $document, gridUtil, uiGridConstants, i18
9695
};
9796

9897

99-
self.hideMenu = $scope.hideMenu = function(event, args) {
98+
$scope.hideMenu = function(event, args) {
10099
if ( $scope.shown ){
101100
/*
102101
* In order to animate cleanly we animate the addition of ng-hide, then use a $timeout to

0 commit comments

Comments
 (0)