Skip to content

Commit 5200747

Browse files
moeyang13mportuga
authored andcommitted
fix: šŸ› don't call needLoadMoreData on last row with cellNav
Unable to edit the last row if both cellNav and infiniteScroll were present (caused infinte refresh loop with scrollDown)
1 parent 4002bd8 commit 5200747

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

ā€Žpackages/infinite-scroll/src/js/infinite-scroll.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,11 +333,14 @@
333333
grid.infiniteScroll.direction = grid.scrollDirection;
334334
delete grid.infiniteScroll.prevScrollTop;
335335

336-
if (grid.scrollDirection === uiGridConstants.scrollDirection.UP && grid.infiniteScroll.scrollUp ) {
336+
if (grid.scrollDirection === uiGridConstants.scrollDirection.UP && grid.infiniteScroll.scrollUp) {
337337
grid.infiniteScroll.dataLoading = true;
338338
grid.api.infiniteScroll.raise.needLoadMoreDataTop();
339339
}
340-
else if (grid.scrollDirection === uiGridConstants.scrollDirection.DOWN && grid.infiniteScroll.scrollDown ) {
340+
else if (grid.scrollDirection === uiGridConstants.scrollDirection.DOWN && grid.infiniteScroll.scrollDown) {
341+
if (grid.cellNav && grid.cellNav.lastRowCol && grid.cellNav.lastRowCol.row.index === grid.infiniteScroll.previousVisibleRows - 1) {
342+
return;
343+
}
341344
grid.infiniteScroll.dataLoading = true;
342345
grid.api.infiniteScroll.raise.needLoadMoreData();
343346
}

0 commit comments

Comments
Ā (0)