Skip to content

Commit 407a2f3

Browse files
committed
Fix null reference in grouping.js
Happens sometimes when having 2 or more colums with sorting and one of the sorted columns has also grouping TypeError: Cannot read property 'expandedState' of null at Object.service.setVisibility (http://localhost/SomeProject/Scripts/angular/ui-grid-3.0.0.rapp.js:16607:63) at Grid.service.groupRows (http://localhost/SomeProject/Scripts/angular/ui-grid-3.0.0.rapp.js:16355:21) at startProcessor (http://localhost/SomeProject/Scripts/angular/ui-grid-3.0.0.rapp.js:4160:33) at handleProcessedRows (http://localhost/SomeProject/Scripts/angular/ui-grid-3.0.0.rapp.js:4176:20) at processQueue (http://localhost/SomeProject/Scripts/angular/angular-1.4.0-beta.6.js:14030:28) at http://localhost/SomeProject/Scripts/angular/angular-1.4.0-beta.6.js:14046:27 at Scope.$eval (http://localhost/SomeProject/Scripts/angular/angular-1.4.0-beta.6.js:15253:28) at Scope.$digest (http://localhost/SomeProject/Scripts/angular/angular-1.4.0-beta.6.js:15068:31) at Scope.$apply (http://localhost/SomeProject/Scripts/angular/angular-1.4.0-beta.6.js:15358:24) at done (http://localhost/SomeProject/Scripts/angular/angular-1.4.0-beta.6.js:9834:47) undefined
1 parent aa56355 commit 407a2f3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/features/grouping/js/grouping.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1413,7 +1413,7 @@
14131413

14141414
var groupLevel = typeof(row.groupLevel) !== 'undefined' ? row.groupLevel : groupingProcessingState.length;
14151415
for (var i = 0; i < groupLevel; i++){
1416-
if ( groupingProcessingState[i].currentGroupHeader.expandedState.state === uiGridGroupingConstants.COLLAPSED ){
1416+
if ( groupingProcessingState[i].currentGroupHeader && groupingProcessingState[i].currentGroupHeader.expandedState.state === uiGridGroupingConstants.COLLAPSED ){
14171417
row.visible = false;
14181418
}
14191419
}

0 commit comments

Comments
 (0)