Skip to content

Commit 709d259

Browse files
committed
refactor(core): clean up canvas and portal
1 parent 136344f commit 709d259

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

libs/core/src/lib/canvas.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ export class NgtCanvas {
9696
created = output<NgtState>();
9797
pointerMissed = outputFromObservable(this.store.get('pointerMissed$'));
9898

99-
glCanvas = viewChild.required<ElementRef<HTMLCanvasElement>>('glCanvas');
100-
glCanvasViewContainerRef = viewChild.required('glCanvas', { read: ViewContainerRef });
99+
private glCanvas = viewChild.required<ElementRef<HTMLCanvasElement>>('glCanvas');
100+
private glCanvasViewContainerRef = viewChild.required('glCanvas', { read: ViewContainerRef });
101101

102102
protected hbPointerEvents = computed(() => (this.eventSource() ? 'none' : 'auto'));
103103

libs/core/src/lib/portal.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -150,20 +150,20 @@ export class NgtPortal {
150150
autoRender = input(false);
151151
autoRenderPriority = input(1);
152152

153-
portalContent = contentChild.required(NgtPortalContent, { read: TemplateRef });
154-
portalAnchor = viewChild.required('anchor', { read: ViewContainerRef });
153+
private portalContent = contentChild.required(NgtPortalContent, { read: TemplateRef });
154+
private portalAnchor = viewChild.required('anchor', { read: ViewContainerRef });
155155

156156
private injector = inject(Injector);
157157
private portalStore = injectStore({ self: true });
158158
private parentStore = injectStore({ skipSelf: true });
159-
parentScene = this.parentStore.select('scene');
160-
parentCamera = this.parentStore.select('camera');
159+
protected parentScene = this.parentStore.select('scene');
160+
protected parentCamera = this.parentStore.select('camera');
161161

162162
private raycaster = new Raycaster();
163163
private pointer = new Vector2();
164164
private portalRendered = signal(false);
165165

166-
renderAutoBeforeRender = computed(() => this.portalRendered() && this.autoRender());
166+
protected renderAutoBeforeRender = computed(() => this.portalRendered() && this.autoRender());
167167

168168
private portalView?: EmbeddedViewRef<unknown>;
169169

0 commit comments

Comments
 (0)