Skip to content

Commit 065efff

Browse files
committed
fix(core): null check remove call
although this doesn't seem like it's doing anything wrong, but this calls for an investigation on destroy logic
1 parent 23f485a commit 065efff

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

libs/core/src/lib/renderer/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,8 @@ export function removeThreeChild(child: NgtInstanceNode, parent?: NgtInstanceNod
145145
cLS?.setParent(null);
146146

147147
// remove child from parent
148-
pLS?.remove(child, 'objects');
149-
pLS?.remove(child, 'nonObjects');
148+
pLS?.remove?.(child, 'objects');
149+
pLS?.remove?.(child, 'nonObjects');
150150

151151
if (parent) {
152152
if (cLS?.attach) {

0 commit comments

Comments
 (0)