feat(nf-core): respect unresolved deps when removing unused shared packages from configuration

Author: manfredsteyer

libs/native-federation-core/package.json

@@ -10,6 +10,6 @@
     "fast-glob": "^3.3.3"
   },
   "peerDependencies": {
-    "@softarc/sheriff-core": "^0.18.0"
+    "@softarc/sheriff-core": "^0.18.2"
   }
 }

libs/native-federation-core/src/lib/core/remove-unused-deps.ts

@@ -60,11 +60,16 @@ function findUsedDeps(
   for (const fileName of Object.keys(fileInfos)) {
     const fileInfo = fileInfos[fileName];
 
-    if (!fileInfo || !fileInfo.externalLibraries) {
+    if (!fileInfo) {
       continue;
     }
 
-    for (const pckg of fileInfo.externalLibraries) {
+    const libs = [
+      ...(fileInfo.externalLibraries || []),
+      ...(fileInfo.unresolvedImports || []),
+    ];
+
+    for (const pckg of libs) {
       usedPackageNames.add(pckg);
     }
 

libs/native-federation-core/src/lib/utils/logger.js

@@ -105,8 +105,12 @@ export default function config(options: MfSchematicSchema): Rule {
 
     const exists = tree.exists(federationConfigPath);
 
-    const cand1 = path.join(projectSourceRoot, 'app', 'app.component.ts').replace(/\\/g, '/');
-    const cand2 = path.join(projectSourceRoot, 'app', 'app.ts').replace(/\\/g, '/');
+    const cand1 = path
+      .join(projectSourceRoot, 'app', 'app.component.ts')
+      .replace(/\\/g, '/');
+    const cand2 = path
+      .join(projectSourceRoot, 'app', 'app.ts')
+      .replace(/\\/g, '/');
 
     const appComponent = tree.exists(cand1)
       ? cand1

libs/native-federation-core/src/lib/utils/logger.js.map

@@ -79,7 +79,7 @@
     "@rollup/plugin-node-resolve": "^15.1.0",
     "@rollup/plugin-replace": "^5.0.2",
     "@schematics/angular": "19.0.0",
-    "@softarc/sheriff-core": "^0.18.0",
+    "@softarc/sheriff-core": "^0.18.2",
     "@swc-node/register": "1.9.2",
     "@swc/cli": "0.6.0",
     "@swc/core": "1.5.7",