feat(nf-core): determine if shared package is already esm

Author: manfredsteyer

libs/native-federation-core/src/lib/core/build-adapter.ts

@@ -12,6 +12,7 @@ export interface BuildAdapterOptions {
   outfile: string;
   mappedPaths: MappedPath[];
   packageName?: string;
+  esm?: boolean;
 }
 
 export type BuildAdapter = (options: BuildAdapterOptions) => Promise<void>;

libs/native-federation-core/src/lib/core/bundle-shared.ts

@@ -45,6 +45,7 @@ export async function bundleShared(
           outfile: cachedFile,
           mappedPaths: config.sharedMappings,
           packageName: pi.packageName,
+          esm: pi.esm,
         });
       }
       catch(e) {

libs/native-federation-core/src/lib/utils/package-info.ts

@@ -5,6 +5,7 @@ export interface PackageInfo {
   packageName: string;
   entryPoint: string;
   version: string;
+  esm: boolean;
 }
 
 export interface PartialPackageJson {
@@ -33,6 +34,7 @@ export function getPackageInfo(
   const mainPkgJson = readJson(mainPkgJsonPath);
 
   const version = mainPkgJson['version'] as string;
+  const esm = mainPkgJson['type'] === 'module';
 
   if (!version) {
     // TODO: Add logger
@@ -49,12 +51,23 @@ export function getPackageInfo(
     relSecondaryPath = './' + relSecondaryPath.replace(/\\/g, '/');
   }
 
-  let cand = mainPkgJson?.exports?.[relSecondaryPath]?.default;
+  let cand = mainPkgJson?.exports?.[relSecondaryPath]?.import;
   if (cand) {
     return {
       entryPoint: path.join(mainPkgPath, cand),
       packageName,
       version,
+      esm
+    };
+  }
+
+  cand = mainPkgJson?.exports?.[relSecondaryPath]?.default;
+  if (cand) {
+    return {
+      entryPoint: path.join(mainPkgPath, cand),
+      packageName,
+      version,
+      esm
     };
   }
 
@@ -65,6 +78,7 @@ export function getPackageInfo(
       entryPoint: path.join(mainPkgPath, cand),
       packageName,
       version,
+      esm: true
     };
   }
 
@@ -80,6 +94,7 @@ export function getPackageInfo(
       entryPoint: path.join(secondaryPgkPath, secondaryPgkJson.module),
       packageName,
       version,
+      esm: true
     };
   }
 
@@ -89,6 +104,7 @@ export function getPackageInfo(
       entryPoint: cand,
       packageName,
       version,
+      esm: true
     };
   }
 
@@ -97,6 +113,7 @@ export function getPackageInfo(
       entryPoint: path.join(secondaryPgkPath, secondaryPgkJson.main),
       packageName,
       version,
+      esm
     };
   }
 
@@ -106,11 +123,12 @@ export function getPackageInfo(
       entryPoint: cand,
       packageName,
       version,
+      esm
     };
   }
 
   // TODO: Add logger
-  console.warn('No esm-based entry point found for ' + packageName);
+  console.warn('No entry point found for ' + packageName);
   console.warn(
     '  >> Did you confuse dependencies with depDependencies in your package.json or your federation config?'
   );

libs/native-federation/src/utils/angular-esbuild-adapter.ts

@@ -7,12 +7,13 @@ import { prepareNodePackage } from './prepare-node-package';
 const SKIP_PACKAGE_PREPARATION = ['@angular', '@ngrx', 'rxjs', 'zone.js'];
 
 export const AngularEsBuildAdapter: BuildAdapter = async (options) => {
-  const { entryPoint, tsConfigPath, external, outfile, mappedPaths, packageName } = options;
+  const { entryPoint, tsConfigPath, external, outfile, mappedPaths, packageName, esm } = options;
 
   const pNameOrEmpty = packageName ?? '';
 
   const preparePackage = entryPoint.includes("node_modules")
-    &&  !SKIP_PACKAGE_PREPARATION.find(p => pNameOrEmpty?.split('/')[0] === p);
+    &&  !(SKIP_PACKAGE_PREPARATION.find(p => pNameOrEmpty?.split('/')[0] === p)
+    || esm);
 
   const pkgName = preparePackage ? inferePkgName(entryPoint) : "";
   const tmpFolder = `node_modules/.tmp/native-federation/${pkgName}`;