fix(lint): fix linting

Author: jogelin

.eslintrc.json

@@ -6,6 +6,7 @@
     {
       "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
       "rules": {
+        "@typescript-eslint/no-explicit-any": "warn",
         "@nx/enforce-module-boundaries": [
           "error",
           {
@@ -24,7 +25,7 @@
     {
       "files": ["*.ts", "*.tsx"],
       "extends": ["plugin:@nx/typescript"],
-      "rules": {}
+      "rules": { "@typescript-eslint/no-explicit-any": "warn" }
     },
     {
       "files": ["*.js", "*.jsx"],

apps/mfe1/src/app/demo/demo.component.ts

@@ -3,7 +3,7 @@ import {
   PlaygroundLibModule,
 } from '@angular-architects/playground-lib';
 import { CommonModule } from '@angular/common';
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 
 @Component({
   standalone: true,

apps/mfe2/src/main.ts

@@ -2,5 +2,5 @@ import { initFederation } from '@angular-architects/native-federation';
 
 initFederation('/assets/federation.manifest.json')
   .catch((err) => console.error(err))
-  .then((_) => import('./bootstrap'))
+  .then(() => import('./bootstrap'))
   .catch((err) => console.error(err));

libs/mf/src/schematics/mf/schematic.ts

@@ -32,7 +32,7 @@ export function add(options: MfSchematicSchema): Rule {
 }
 
 export function adjustSSR(sourceRoot: string, ssrMappings: string): Rule {
-  return async function (tree, context) {
+  return async function (tree) {
     const server = path.join(sourceRoot, 'server.ts');
 
     if (!tree.exists(server)) {
@@ -70,7 +70,7 @@ const ssrEngine = new Engine();
 }
 
 function makeMainAsync(main: string, options: MfSchematicSchema): Rule {
-  return async function (tree, context) {
+  return async function (tree) {
     const mainPath = path.dirname(main);
     const bootstrapName = path.join(mainPath, 'bootstrap.ts');
 
@@ -267,8 +267,7 @@ export default function config(options: MfSchematicSchema): Rule {
         projectName,
         remotes,
         relTsConfigPath,
-        projectRoot,
-        port
+        projectRoot
       );
       tree.create(configPath, webpackConfig);
     } else {

libs/mf/src/schematics/migrate-to-13/schematic.ts

@@ -1,10 +1,10 @@
 import { Rule } from '@angular-devkit/schematics';
 
 export function index(): Rule {
-  return async function (tree, context) {
+  return async function () {
     console.info(`!!!
-Angular 13 compiles bundles as EcmaScript modules. 
-Hence, we need to adjust how we use Module Federation. 
+Angular 13 compiles bundles as EcmaScript modules.
+Hence, we need to adjust how we use Module Federation.
 We've got you covered. Please find all information here:
 https://github.com/angular-architects/module-federation-plugin/blob/main/migration-guide.md
 !!!

libs/mf/src/schematics/migrate-to-14-3/schema.d.ts

@@ -1 +1 @@
-type BootAsyncSchema = {};
+type BootAsyncSchema = object;

libs/mf/src/utils/create-config.ts

@@ -4,8 +4,7 @@ export function createConfig(
   projectName: string,
   remotes: string,
   tsConfigName: string,
-  root: string,
-  port: number
+  root: string
 ): string {
   return `const ModuleFederationPlugin = require("webpack/lib/container/ModuleFederationPlugin");
 const mf = require("@angular-architects/module-federation/webpack");
@@ -24,7 +23,7 @@ module.exports = {
   },
   optimization: {
     runtimeChunk: false
-  },   
+  },
   resolve: {
     alias: {
       ...sharedMappings.getAliases(),
@@ -42,22 +41,22 @@ module.exports = {
         // filename: "remoteEntry.js",
         // exposes: {
         //     './Component': './${root}/src/app/app.component.ts',
-        // },        
-        
+        // },
+
         // For hosts (please adjust)
         // remotes: {
 ${remotes}
         // },
 
         shared: share({
-          "@angular/core": { singleton: true, strictVersion: true, requiredVersion: 'auto' }, 
-          "@angular/common": { singleton: true, strictVersion: true, requiredVersion: 'auto' }, 
-          "@angular/common/http": { singleton: true, strictVersion: true, requiredVersion: 'auto' }, 
+          "@angular/core": { singleton: true, strictVersion: true, requiredVersion: 'auto' },
+          "@angular/common": { singleton: true, strictVersion: true, requiredVersion: 'auto' },
+          "@angular/common/http": { singleton: true, strictVersion: true, requiredVersion: 'auto' },
           "@angular/router": { singleton: true, strictVersion: true, requiredVersion: 'auto' },
 
           ...sharedMappings.getDescriptors()
         })
-        
+
     }),
     sharedMappings.getPlugin()
   ],

libs/mf/src/utils/share-utils.ts

@@ -296,7 +296,10 @@ export function share(
   return result;
 }
 
-function addSecondaries(secondaries: Record<string, SharedConfig>, result: {}) {
+function addSecondaries(
+  secondaries: Record<string, SharedConfig>,
+  result: object
+) {
   for (const key in secondaries) {
     result[key] = secondaries[key];
   }

libs/native-federation-core/src/lib/config/share-utils.ts

@@ -65,14 +65,15 @@ function findPackageJson(folder: string): string {
   );
 }
 
-function readVersionMap(packagePath: string): VersionMap {
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
-  const json = require(packagePath);
-  const versions = {
-    ...json['dependencies'],
-  };
-  return versions;
-}
+// TODO: Unused, to delete?
+// function readVersionMap(packagePath: string): VersionMap {
+//   // eslint-disable-next-line @typescript-eslint/no-var-requires
+//   const json = require(packagePath);
+//   const versions = {
+//     ...json['dependencies'],
+//   };
+//   return versions;
+// }
 
 function lookupVersion(key: string, workspaceRoot: string): string {
   const versionMaps = getVersionMaps(workspaceRoot, workspaceRoot);

libs/native-federation-core/src/lib/config/with-native-federation.ts

@@ -1,5 +1,5 @@
 import { getMappedPaths, MappedPath } from '../utils/mapped-paths';
-import { shareAll, share, findRootTsConfigJson } from './share-utils';
+import { shareAll, findRootTsConfigJson } from './share-utils';
 import {
   FederationConfig,
   NormalizedFederationConfig,