Skip to content

Commit 180de7b

Browse files
committed
fix(nf): activate code splitting in esbuild adapter
1 parent 80aacae commit 180de7b

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

libs/native-federation/migrate-appbuilder.md

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ This requires some changes in the `angular.json`. If you go with a default confi
77
```
88
ng g @angular-architects/native-federation:appbuilder
99
```
10+
1011
You need to run this command for each application using Native Federation.
1112

1213
For more advanced cases, please find a diff of the changes needed for this version:

libs/native-federation/src/builders/build/builder.ts

+7-2
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,16 @@ export async function* runBuilder(
6363
let builder = await context.getBuilderNameForTarget(target);
6464

6565
if (builder === '@angular-devkit/build-angular:browser-esbuild') {
66-
logger.info('.: UPDATE NEEDED :.');
66+
logger.info('.: NATIVE FEDERATION - UPDATE NEEDED :.');
6767
logger.info('');
6868
logger.info("Since version 17.1, Native Federation uses Angular's");
6969
logger.info('Application-Builder and its Dev-Server.');
70-
logger.info('Please update your project config, e.g. in angular.json');
70+
logger.info('');
71+
logger.info('If you are sill on Angular 17.0.x, please update to');
72+
logger.info('Angular 17.1.x or downgrade to Native Federation 17.0.x.');
73+
logger.info('');
74+
logger.info('For working with Native Federation 17.1.x (recommented), ');
75+
logger.info('please update your project config, e.g. in angular.json');
7176
logger.info('');
7277
logger.info('This command performs the needed update for default configs:');
7378
logger.info('');

libs/native-federation/src/utils/angular-esbuild-adapter.ts

+1
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,7 @@ async function runEsbuild(
268268
'async-await': false,
269269
'object-rest-spread': false,
270270
},
271+
splitting: true,
271272
platform: 'browser',
272273
format: 'esm',
273274
target: ['esnext'],

0 commit comments

Comments
 (0)