Enable some previously disabled pylint rules #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justifications for each of these:
abstract-method: This applies when an abstract method is not overridden in a child class but that class is not marked as being abstract itself. This seems like something we would want?len-as-condition: The argument is basically if you are only doinglen(thing)as a condition, you should just usethingdirectly. Seems valid to me.no-else-return: Already covered by ruffprotected-access: This one will probably show up a lot but this is something I believe we should actively be looking to correct when possible.unidiomatic-typecheck: Covered by ruff already in some repos, seems like a good rule.consider-using-f-strong: Covered by ruff already