Skip to content

Commit ed92519

Browse files
committed
Add more generous try timeout for multiple pipelines specs
Fixes elastic#9225
1 parent 76a0cb0 commit ed92519

File tree

2 files changed

+1
-19
lines changed

2 files changed

+1
-19
lines changed

logstash-core/spec/logstash/agent_spec.rb

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -132,14 +132,9 @@
132132

133133
it "does not upgrade the new config" do
134134
t = Thread.new { subject.execute }
135-
<<<<<<< HEAD
136-
sleep(0.01) until subject.with_pipelines {|pipelines| subject.running_pipelines? && pipelines.values.first.ready? }
137-
138-
=======
139135
Timeout.timeout(timeout) do
140136
sleep(0.01) until subject.running_pipelines? && subject.pipelines.values.first.ready?
141137
end
142-
>>>>>>> a1c0e417e5... Support for inter-pipeline comms with a new pipeline input/output
143138
expect(subject.converge_state_and_update).not_to be_a_successful_converge
144139
expect(subject).to have_running_pipeline?(mock_config_pipeline)
145140

@@ -157,13 +152,9 @@
157152

158153
it "does upgrade the new config" do
159154
t = Thread.new { subject.execute }
160-
<<<<<<< HEAD
161-
sleep(0.01) until subject.with_pipelines {|pipelines| subject.pipelines_count > 0 && pipelines.values.first.ready? }
162-
=======
163155
Timeout.timeout(timeout) do
164156
sleep(0.01) until subject.pipelines_count > 0 && subject.pipelines.values.first.ready?
165157
end
166-
>>>>>>> a1c0e417e5... Support for inter-pipeline comms with a new pipeline input/output
167158

168159
expect(subject.converge_state_and_update).to be_a_successful_converge
169160
expect(subject).to have_running_pipeline?(mock_second_pipeline_config)
@@ -185,14 +176,9 @@
185176

186177
it "does not try to reload the pipeline" do
187178
t = Thread.new { subject.execute }
188-
<<<<<<< HEAD
189-
sleep(0.01) until subject.with_pipelines {|pipelines| subject.running_pipelines? && pipelines.values.first.running? }
190-
191-
=======
192179
Timeout.timeout(timeout) do
193180
sleep(0.01) until subject.running_pipelines? && subject.pipelines.values.first.running?
194181
end
195-
>>>>>>> a1c0e417e5... Support for inter-pipeline comms with a new pipeline input/output
196182
expect(subject.converge_state_and_update).not_to be_a_successful_converge
197183
expect(subject).to have_running_pipeline?(mock_config_pipeline)
198184

@@ -210,13 +196,9 @@
210196

211197
it "tries to reload the pipeline" do
212198
t = Thread.new { subject.execute }
213-
<<<<<<< HEAD
214-
sleep(0.01) until subject.with_pipelines {|pipelines| subject.running_pipelines? && pipelines.values.first.running? }
215-
=======
216199
Timeout.timeout(timeout) do
217200
sleep(0.01) until subject.running_pipelines? && subject.pipelines.values.first.running?
218201
end
219-
>>>>>>> a1c0e417e5... Support for inter-pipeline comms with a new pipeline input/output
220202

221203
expect(subject.converge_state_and_update).to be_a_successful_converge
222204
expect(subject).to have_running_pipeline?(mock_second_pipeline_config)

qa/integration/specs/multiple_pipeline_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
let!(:pipelines_yaml) { pipelines.to_yaml }
3838
let!(:pipelines_yaml_file) { ::File.join(settings_dir, "pipelines.yml") }
3939

40-
let(:retry_attempts) { 30 }
40+
let(:retry_attempts) { 40 }
4141

4242
before(:each) do
4343
IO.write(pipelines_yaml_file, pipelines_yaml)

0 commit comments

Comments
 (0)