Skip to content

Commit 2ad0e8a

Browse files
committed
Error in start
1 parent b0777de commit 2ad0e8a

File tree

4 files changed

+242
-25
lines changed

4 files changed

+242
-25
lines changed

packages/react-library-scripts/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"@babel/preset-env": "^7.6.3",
2121
"@babel/preset-react": "^7.6.3",
2222
"babel-plugin-module-resolver": "^3.2.0",
23+
"babel-preset-react-app": "^9.0.2",
2324
"html-webpack-plugin": "^3.2.0",
2425
"open": "^7.0.0",
2526
"webpack": "^4.41.2",

packages/react-library-scripts/scripts/start.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const Webpack = require("webpack");
77
const WebpackDevServer = require("webpack-dev-server");
88
const open = require("open");
99
const config = require("../configs/webpack.config.js");
10-
const verifyPort = require("../utils/verifyPort");
10+
const portChecker = require("../utils/portChecker");
1111
const resolverPath = require("../utils/resolverPath");
1212

1313
const APP_PATH = resolverPath("src/dev");
@@ -19,8 +19,7 @@ const server = new WebpackDevServer(compiler, {
1919
});
2020

2121
const PORT = process.env.PORT || 3000;
22-
const baseUrl = "http://localhost";
2322

24-
verifyPort(PORT, baseUrl, newPort => {
25-
server.listen(newPort, "localhost", () => open(`${baseUrl}:${newPort}`));
26-
});
23+
portChecker(PORT, newPort =>
24+
server.listen(newPort, "localhost", () => open(`http://localhost:${newPort}`))
25+
);

packages/react-library-scripts/utils/portChecker.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,17 @@
1+
"use strict";
2+
13
const net = require("net");
24

3-
const portChecker = (port, base, callback) => {
5+
const portChecker = (port, callback) => {
46
const server = net.createServer(socket => {
57
socket.write("Echo server\r\n");
68
socket.pipe(socket);
79
});
810

9-
server.listen(port, base);
11+
server.listen(port, "127.0.0.1");
1012

1113
server.on("error", () => {
12-
portChecker(port + 1, base, newPort => callback(newPort));
14+
portChecker(port + 1, newPort => callback(newPort));
1315
});
1416

1517
server.on("listening", () => {

0 commit comments

Comments
 (0)