From d51744b816d608fb16f31751f4424f3ace33bc88 Mon Sep 17 00:00:00 2001 From: Ben Allen Date: Tue, 2 Apr 2024 16:57:41 -0700 Subject: [PATCH] Apply suggestions from code review Several clarifications from @gibson42 Co-authored-by: Richard Gibson --- spec/datetimeformat.html | 16 ++++++++-------- spec/locales-currencies-tz.html | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/spec/datetimeformat.html b/spec/datetimeformat.html index cea5eeca..f0eb4680 100644 --- a/spec/datetimeformat.html +++ b/spec/datetimeformat.html @@ -161,7 +161,7 @@

1. Let _bestFormat_ be BasicFormatMatcher(_formatOptions_, _formats_). 1. Else, 1. Let _bestFormat_ be BestFitFormatMatcher(_formatOptions_, _formats_). - 1. Set _dateTimeFormat_.[[DateTimeFormat]] to _bestFormat_. + 1. Set _dateTimeFormat_.[[Patterns]] to _bestFormat_. 1. If _bestFormat_ has a field [[hour]], then 1. Set _dateTimeFormat_.[[HourCycle]] to _hc_. 1. Return _dateTimeFormat_. @@ -258,7 +258,7 @@

Internal slots

[[LocaleData]].[[<_locale_>]].[[hourCycle24]] must be a String value equal to *"h23"* or *"h24"*.
  • - [[LocaleData]].[[<_locale_>]] must have a [[formats]] field. This [[formats]] field must be a Record with [[<_calendar_>]] fields for all calendar values _calendar_. The value of this field must be a List of DateTime Format Records. Multiple Records in a List may use the same subset of the fields as long as they have different values for the fields. The following subsets must be available for each locale: + [[LocaleData]].[[<_locale_>]] must have a [[formats]] field. The value of this [[formats]] field must be a Record with a [[<_calendar_>]] field for each calendar value _calendar_. The value of each [[<_calendar_>]] field must be a List of DateTimeFormat Patterns Record. Multiple Records in such a List may use the same subset of the fields as long as the corresponding values differ for at least one field. The following subsets must be available for each locale:
    • weekday, year, month, day, hour, minute, second, fractionalSecondDigits
    • weekday, year, month, day, hour, minute, second
      • @@ -275,18 +275,18 @@

      Internal slots

  • - [[LocaleData]].[[<_locale_>]] must have a [[styles]] field. The [[styles]] field must be a Record with [[<_calendar_>]] fields for all calendar values _calendar_. The value of this field is a DateTime Calendar Style Record. + [[LocaleData]].[[<_locale_>]] must have a [[styles]] field. The value of this [[styles]] field must be a Record with a [[<_calendar_>]] field for each calendar value _calendar_. The value of each [[<_calendar_>]] field must be a DateTimeFormat Styles Record.
    • - -

    DateTime Format Records

    + +

    DateTimeFormat Patterns Records

    - Each DateTime Format Record has the fields defined in . + Each DateTimeFormat Patterns Record has the fields defined in .

    - - DateTime Time Range Record + + DateTimeFormat Patterns Record diff --git a/spec/locales-currencies-tz.html b/spec/locales-currencies-tz.html index 6cd945bb..e4a6c576 100644 --- a/spec/locales-currencies-tz.html +++ b/spec/locales-currencies-tz.html @@ -418,7 +418,7 @@

    Pattern String Types

    - Pattern String is a String value which contains zero or more substrings of the form *"{name}"*. The syntax of the abstract pattern strings is an implementation detail and is not exposed to users of ECMA-402. + Pattern String is a String value which contains zero or more substrings of the form *"{key}"*, where key can be any nonempty sequence consisting only of elements from the ASCII word characters. The syntax of the abstract pattern strings is an implementation detail and is not exposed to users of ECMA-402.