Skip to content

Commit 18d273d

Browse files
kunalbfacebook-github-bot
authored andcommitted
[RFC][LocalSession] Fix workspace type
Summary: I was reading/looking into how LocalSession works and realized that the workspace type being passed around was the bound function on TaskGroup instead of the actual type. This meant that all workspaces for localsession would always be global, because they'd never match the private workspace type. Test Plan: <not sure, could use some suggestions> Reviewed By: cryptopic Differential Revision: D24458428 fbshipit-source-id: 0f87874babe9c1ddff25b5363b443f9ca37e03c1
1 parent d0df29a commit 18d273d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

caffe2/python/session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ def _compile_task_group(cls, task_group, setup_net_list=None):
192192
task = task_group.to_task()
193193
plan = core.Plan('task_group_plan')
194194
plan.AddStep(task.get_step())
195-
return (plan, task.output_list(), task.workspace_type)
195+
return (plan, task.output_list(), task.workspace_type())
196196

197197
def _run_compiled(self, compiled):
198198
plan, output_list, workspace_type = compiled

0 commit comments

Comments
 (0)