Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Analyzer - Smith Chart #519

Open
amiclaus opened this issue Dec 10, 2018 · 1 comment
Open

Network Analyzer - Smith Chart #519

amiclaus opened this issue Dec 10, 2018 · 1 comment
Assignees
Labels
enhancement network analyzer TBD to be determined/decided - needs more definition

Comments

@amiclaus
Copy link
Contributor

amiclaus commented Dec 10, 2018

Based on reviews, some people might prefer using the Smith Chart for data visualization.

Is this a reasonable feature that can be implemented?

Reference: https://youtu.be/pNHWq4Owsb4

@rlemerts
Copy link

rlemerts commented Feb 19, 2019

Looking at the schematics and network analyzer code I would suggest splitting this into two different instruments:

  • a Vector Network Analyzer for two-port measurements with a Smith Chart display
  • transfer function plotter for the already implemented behavior with logarithmic charts

The VNA could put the hardware into the DAC calibration configuration in order to make the connections neater and avoid needing to figure out which ADC is connected to which port. Just did the math, that would limit it to about 1Mhz. Additionally it would necessarily work as an impedance analyzer, just a little bit of math on the reflection coefficient.

That being said, I would appreciate an option to use that calibration path for measurements; but that might be a separate feature request.

@adisuciu adisuciu added the TBD to be determined/decided - needs more definition label Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement network analyzer TBD to be determined/decided - needs more definition
Projects
None yet
Development

No branches or pull requests

3 participants