-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ac coupling not working as intended #1885
Comments
Hi, The plot channel handle is directly linked to Vertical Position knob. But the position on the plot can only be described as relative to the Vertical Volts/Division value. So when modifying the Volts/Dev value from 10mV to 3mV, the handle will maintain its value of 13mV and visually move on the plot. -Alexandra |
The way i see it and how it works with some oscilloscopes (I'm not certain it works like this for all of them) is that when ac coupling mode is applied, the vertical position will not move when changing the volt/div knob. And this makes sense since we have completely eliminated the dc offset. The vertical position in the current case acts like the DC part of the signal when in fact the signal shouldn't have any dc in it, and in turn it moves the signal with the volts/div knob. This could be implemented in a way that when ac coupling is enabled, the vertical position (In volts) is grayed to indicate it being disabled and use a different variable which indicates the relative position of the trace in relation to the graph (10 divisions in total so a number from +5 to -5 float), and when maybe you change from ac to dc coupling, you convert that relative value to the one corresponding to the position in volts like before. I also want to add that the "enhancement" label might be more appropriate for this issue. Please correct me if have said any nonsense since without a scope in my hands right now I can't verify the things i indicated above. |
Environment:
Describe the bug
The issue i'm describing is related to the software ac coupling. The main problem is that when you set the vertical cursor of the trace other than 0 (by double tapping), the cursor will move in relation to the vertical voltage knob, which isn't really the intended purpose of the function.
I'm not sure if this problem is present in 1.5 or earlier versions.
Expected behavior
The ideal behavior would be to have the vertical trace fixed on the relative position of the graph instead of the voltage.
Screenshots
(the screenshots are pretty self explanatory, changing the vertical scale changes the position of the trace which isn't ideal)
If further info is required, i'll provide it.
The text was updated successfully, but these errors were encountered: