Skip to content

Panic on Linux when no editor running #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
randomPoison opened this issue Oct 5, 2018 · 3 comments
Closed

Panic on Linux when no editor running #15

randomPoison opened this issue Oct 5, 2018 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@randomPoison
Copy link
Member

Original bug report from @Jojolepro:

Using amethyst-editor-sync in a game when the editor is closed leads to a crash.
thread '' panicked at 'Failed to send message: Os { code: 111, kind: ConnectionRefused, message: "Connection refused" }

I should note that I don't see this issue on Windows, and it's a very weird issue considering we're using UDP, which doesn't actually have a concept of connections 🤔 This might be because we're using UdpSocket::connect.

Note that while this might be easy to solve for UDP, we also want to switch to TCP in order to fix #12, so we'd end up running into the same issue with TCP anyway.

@randomPoison randomPoison added the bug Something isn't working label Oct 5, 2018
@randomPoison
Copy link
Member Author

Note that this issue is causing problems for running automated tests under Travis-CI because the tests are run under Linux and there's no editor to connect to.

@randomPoison randomPoison added this to the Version 0.2 milestone Oct 5, 2018
@randomPoison
Copy link
Member Author

@Jojolepro could you try patching in the latest commit on master (3b2d82d) and see if you still see this issue happening? If so, I can re-open this issue, but otherwise it seems fixed when running on Travis-CI.

@AnneKitsune
Copy link

Can't reproduce on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants