Skip to content

Commit 15df2c8

Browse files
author
Ivelin Ivanov
authored
Merge pull request #19 from ambianic/dev
fix: polish shutdown sequence
2 parents 2ca1206 + 161394c commit 15df2c8

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

src/peerjs/ext/http-proxy.py

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
# flags when user requests shutdown
3737
# via CTRL+C or another system signal
38-
_shutdown: bool = False
38+
_is_shutting_down: bool = False
3939

4040

4141
# async def _consume_signaling(pc, signaling):
@@ -60,7 +60,7 @@ async def join_peer_room(peer=None):
6060
myRoom = PeerRoom(peer)
6161
log.debug('Fetching room members...')
6262
peerIds = await myRoom.getRoomMembers()
63-
log.debug('myRoom members %r', peerIds)
63+
log.info('myRoom members %r', peerIds)
6464

6565

6666
def _savePeerId(peerId=None):
@@ -113,8 +113,8 @@ async def peer_disconnected(peerId):
113113
'Resetting to last known ID.')
114114
peer._id = savedPeerId
115115
peer._lastServerId = savedPeerId
116-
global _shutdown
117-
if not _shutdown:
116+
global _is_shutting_down
117+
if not _is_shutting_down:
118118
await peer.reconnect()
119119

120120
@peer.on(PeerEventType.Close)
@@ -201,15 +201,20 @@ async def pnp_service_connect() -> Peer:
201201
await peer.start()
202202
log.info('peer activated')
203203
_setPnPServiceConnectionHandlers(peer)
204+
log.info('Calling make_discoverable')
204205
await make_discoverable(peer=peer)
206+
log.info('Exited make_discoverable')
205207

206208

207209
async def make_discoverable(peer=None):
208210
"""Enable remote peers to find and connect to this peer."""
211+
log.debug('Enter peer discoverable.')
209212
assert peer
210-
global _shutdown
211-
while not _shutdown:
212-
log.debug('Making peer discoverable.')
213+
log.debug('Before _is_shutting_down')
214+
global _is_shutting_down
215+
log.debug('Making peer discoverable.')
216+
while not _is_shutting_down:
217+
log.debug('Discovery loop.')
213218
try:
214219
# check if the websocket connection
215220
# to the signaling server is alive
@@ -247,8 +252,8 @@ def _config_logger():
247252

248253

249254
def _shutdown():
250-
global _shutdown
251-
_shutdown = True
255+
global _is_shutting_down
256+
_is_shutting_down = True
252257
loop = asyncio.get_event_loop()
253258
if peer:
254259
loop.run_until_complete(peer.destroy())

0 commit comments

Comments
 (0)