Skip to content

Commit 5fb52d8

Browse files
oCaioOliveiraalradish
authored andcommitted
Add "how to adopt pull requests" section (bevyengine#6895)
# Objective - Add "how to adopt pull requests" section. - Fixes bevyengine#5539 ## Solution - Add "how to adopt pull requests" section in [Contributing.md](https://github.com/bevyengine/bevy/blob/main/CONTRIBUTING.md). Co-authored-by: Erick <[email protected]>
1 parent 4b1ed7d commit 5fb52d8

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

CONTRIBUTING.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,26 @@ By giving feedback on this work (and related supporting work), you can help us m
275275
Finally, if nothing brings you more satisfaction than seeing every last issue labeled and all resolved issues closed, feel free to message @cart for a Bevy org role to help us keep things tidy.
276276
As discussed in [*How we're organized*](#how-were-organized), this role only requires good faith and a basic understanding of our development process.
277277

278+
### How to adopt pull requests
279+
280+
Occasionally authors of pull requests get busy or become unresponsive, or project members fail to reply in a timely manner.
281+
This is a natural part of any open source project.
282+
To avoid blocking these efforts, these pull requests may be *adopted*, where another contributor creates a new pull request with the same content.
283+
If there is an old pull request that is without updates, comment to the organization whether it is appropriate to add the
284+
*[S-Adopt-Me](https://github.com/bevyengine/bevy/labels/S-Adopt-Me)* label, to indicate that it can be *adopted*.
285+
If you plan on adopting a PR yourself, you can also leave a comment on the PR asking the author if they plan on returning.
286+
If the author gives permission or simply doesn't respond after a few days, then it can be adopted.
287+
This may sometimes even skip the labeling process since at that point the PR has been adopted by you.
288+
289+
With this label added, it's best practice to fork the original author's branch.
290+
This ensures that they still get credit for working on it and that the commit history is retained.
291+
When the new pull request is ready, it should reference the original PR in the description.
292+
Then notify org members to close the original.
293+
294+
* For example, you can reference the original PR by adding the following to your PR description:
295+
296+
`Adopted #number-original-pull-request`
297+
278298
### Maintaining code
279299

280300
Maintainers can merge uncontroversial pull requests that have at least two approvals (or at least one for trivial changes).

0 commit comments

Comments
 (0)