Merge pull request #706 from alphagov/remove-unused-rack-cors

Remove unused Rack::Cors plugin

Author: benthorner

Gemfile

@@ -21,7 +21,6 @@ gem 'mime-types', '~> 3.1'
 gem 'pg', '~> 0.18'
 gem 'plek'
 gem 'puma', '~> 3.7'
-gem 'rack-cors', require: 'rack/cors'
 gem 'rails', '~> 5.1.6'
 gem 'rest-client', '~> 2.0.2'
 gem 'rubyzip', '~> 1.2'

Gemfile.lock

@@ -252,7 +252,6 @@ GEM
     rack (2.0.4)
     rack-cache (1.7.1)
       rack (>= 0.4)
-    rack-cors (1.0.1)
     rack-protection (2.0.1)
       rack
     rack-test (1.0.0)
@@ -453,7 +452,6 @@ DEPENDENCIES
   pry-rails
   pry-stack_explorer (~> 0.4.9)
   puma (~> 3.7)
-  rack-cors
   rails (~> 5.1.6)
   rest-client (~> 2.0.2)
   rspec (~> 3.6)

config/application.rb

@@ -40,22 +40,10 @@ class Application < Rails::Application
       html_tag
     }
 
-    # TODO: replace the origins wildcard to accept requets from find only?
-    # https://github.com/cyu/rack-cors#origin
-    config.middleware.insert_before 0, Rack::Cors do
-      allow do
-        origins '*'
-        resource '*', headers: :any, methods: [:get]
-      end
-    end
-
     config.autoload_paths += [Rails.root.join("app/workers")]
     config.autoload_paths += [Rails.root.join("lib/validators")]
     config.autoload_paths += [Rails.root.join("lib/ckan")]
 
     config.elasticsearch = config_for(:elasticsearch)
-
-    config.filter_parameters << :password
-    config.filter_parameters << :password_confirmation
   end
 end