Merge pull request #1095 from alphagov/update-build-type

Update build_type method to use correct API

Author: owenatgov

app/services/ckan/v26/link_mapper.rb

@@ -40,8 +40,8 @@ def build_name(resource)
       end
 
       def build_type(resource)
-        type = resource.get("resource_type")
-        type == "documentation" ? "Doc" : "Datafile"
+        type = resource.get("resource-type")
+        type == "supporting-document" ? "Doc" : "Datafile"
       end
     end
   end

spec/fixtures/files/ckan/v26/package_show_update.json

@@ -112,7 +112,7 @@
                 "position": 1,
                 "revision_id": "a0372fbf-c991-436c-b0a5-744d499054ee",
                 "id": "b7e53746-1154-425d-a85d-5bb03eb3f310",
-                "resource_type": "documentation",
+                "resource-type": "supporting-document",
                 "name": "Landing page"
             }
         ],
@@ -196,7 +196,7 @@
                 "position": 1,
                 "revision_id": "a0372fbf-c991-436c-b0a5-744d499054ee",
                 "id": "b7e53746-1154-425d-a85d-5bb03eb3f310",
-                "resource_type": "documentation",
+                "resource-type": "supporting-document",
                 "name": "Landing page"
             }
         ],

spec/services/ckan/v26/link_mapper_spec.rb

@@ -17,7 +17,7 @@
     end
 
     it "correctly distinguishes between datafiles and docs" do
-      resource = build :ckan_v26_resource, resource_type: "documentation"
+      resource = build :ckan_v26_resource, "resource-type": "supporting-document"
       attributes = subject.call(resource, dataset)
       expect(attributes[:type]).to eq "Doc"
     end