Bump govuk-lint from 3.11.0 to 3.11.2 (#742)

Bump govuk-lint from 3.11.0 to 3.11.2

Author: Alan Gabbianelli

Gemfile.lock

@@ -122,7 +122,7 @@ GEM
       warden-oauth2 (~> 0.0.1)
     globalid (0.4.2)
       activesupport (>= 4.2.0)
-    govuk-lint (3.11.0)
+    govuk-lint (3.11.2)
       rubocop (~> 0.64)
       rubocop-rspec (~> 1.28)
       scss_lint
@@ -228,8 +228,8 @@ GEM
     omniauth-oauth2 (1.3.1)
       oauth2 (~> 1.0)
       omniauth (~> 1.2)
-    parallel (1.14.0)
-    parser (2.6.2.0)
+    parallel (1.17.0)
+    parser (2.6.3.0)
       ast (~> 2.4.0)
     pg (0.21.0)
     plek (2.1.1)
@@ -245,7 +245,6 @@ GEM
     pry-stack_explorer (0.4.9.3)
       binding_of_caller (>= 0.7)
       pry (>= 0.9.11)
-    psych (3.1.0)
     public_suffix (3.1.0)
     puma (3.12.1)
     raabro (1.1.5)
@@ -315,17 +314,16 @@ GEM
       rspec-mocks (~> 3.6.0)
       rspec-support (~> 3.6.0)
     rspec-support (3.6.0)
-    rubocop (0.66.0)
+    rubocop (0.71.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
-      parser (>= 2.5, != 2.5.1.1)
-      psych (>= 3.1.0)
+      parser (>= 2.6)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.6)
-    rubocop-rspec (1.32.0)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    rubocop-rspec (1.33.0)
       rubocop (>= 0.60.0)
-    ruby-progressbar (1.10.0)
+    ruby-progressbar (1.10.1)
     ruby_dep (1.5.0)
     rubyzip (1.2.2)
     rufus-scheduler (3.5.0)
@@ -342,7 +340,7 @@ GEM
       sprockets (>= 2.8, < 4.0)
       sprockets-rails (>= 2.0, < 4.0)
       tilt (>= 1.1, < 3)
-    scss_lint (0.57.1)
+    scss_lint (0.58.0)
       rake (>= 0.9, < 13)
       sass (~> 3.5, >= 3.5.5)
     sentry-raven (2.7.4)
@@ -399,7 +397,7 @@ GEM
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.7.6)
-    unicode-display_width (1.5.0)
+    unicode-display_width (1.6.0)
     unicorn (5.4.1)
       kgio (~> 2.6)
       raindrops (~> 0.7)

spec/controllers/datasets_controller_spec.rb

@@ -9,10 +9,12 @@
   end
 
   it "redirects to slugged URL" do
-    dataset = FactoryBot.create(:dataset,
-                                 name: "legit-name",
-                                 organisation: organisation,
-                                 datafiles: [FactoryBot.create(:datafile)])
+    dataset = FactoryBot.create(
+      :dataset,
+      name: "legit-name",
+      organisation: organisation,
+      datafiles: [FactoryBot.create(:datafile)]
+    )
 
     get :show, params: { uuid: dataset.uuid, name: "absolute-nonsense-name" }
 
@@ -22,13 +24,17 @@
   it "returns '503 forbidden' error if a user is not allowed to view the requested dataset" do
     another_organisation = FactoryBot.create(:organisation)
 
-    _allowed_dataset = FactoryBot.create(:dataset,
-                                          organisation: organisation,
-                                          datafiles: [FactoryBot.create(:datafile)])
+    _allowed_dataset = FactoryBot.create(
+      :dataset,
+      organisation: organisation,
+      datafiles: [FactoryBot.create(:datafile)]
+    )
 
-    forbidden_dataset = FactoryBot.create(:dataset,
-                                           organisation: another_organisation,
-                                           datafiles: [FactoryBot.create(:datafile)])
+    forbidden_dataset = FactoryBot.create(
+      :dataset,
+      organisation: another_organisation,
+      datafiles: [FactoryBot.create(:datafile)]
+    )
 
     get :show, params: { uuid: forbidden_dataset.uuid, name: forbidden_dataset.name }
 
@@ -38,13 +44,17 @@
   it "returns '503 forbidden' error if a user is not allowed to update the requested dataset" do
     another_organisation = FactoryBot.create(:organisation)
 
-    _allowed_dataset = FactoryBot.create(:dataset,
-                                          organisation: organisation,
-                                          datafiles: [FactoryBot.create(:datafile)])
-
-    forbidden_dataset = FactoryBot.create(:dataset,
-                                           organisation: another_organisation,
-                                           datafiles: [FactoryBot.create(:datafile)])
+    _allowed_dataset = FactoryBot.create(
+      :dataset,
+      organisation: organisation,
+      datafiles: [FactoryBot.create(:datafile)]
+    )
+
+    forbidden_dataset = FactoryBot.create(
+      :dataset,
+      organisation: another_organisation,
+      datafiles: [FactoryBot.create(:datafile)]
+    )
 
     get :edit, params: { uuid: forbidden_dataset.uuid, name: forbidden_dataset.name }
 

spec/features/ckan_v26_package_sync_spec.rb

@@ -16,7 +16,8 @@
   let!(:dataset_to_ignore) { create :dataset, legacy_name: nil }
 
   let!(:dataset_to_reimport) {
-    create(:dataset,
+    create(
+      :dataset,
       legacy_name: "dataset_to_reimport",
       uuid: search_dataset_p1["results"][3]["id"],
       status: "draft",

spec/features/dataset_publish_spec.rb

@@ -5,8 +5,7 @@
   let(:user) { create(:user, primary_organisation: land) }
 
   let!(:dataset) do
-    create :dataset, :with_datafile, :with_doc,
-                     creator: user, organisation: land
+    create(:dataset, :with_datafile, :with_doc, creator: user, organisation: land)
   end
 
   before do

spec/models/dataset_spec.rb

@@ -20,16 +20,13 @@
   end
 
   it "generates a unique slug and stores it on the name column" do
-    dataset = FactoryBot.create(:dataset,
-                                 title: "My awesome dataset")
+    dataset = FactoryBot.create(:dataset, title: "My awesome dataset")
 
     expect(dataset.name).to eq(dataset.title.parameterize)
   end
 
   it "generates a new slug when the title has changed" do
-    dataset = FactoryBot.create(:dataset,
-                                 uuid: 1234,
-                                 title: "My awesome dataset")
+    dataset = FactoryBot.create(:dataset, uuid: 1234, title: "My awesome dataset")
 
     dataset.update(title: "My Even Better Dataset")