Skip to content
This repository was archived by the owner on Jan 24, 2025. It is now read-only.

Commit 7134358

Browse files
authored
Merge pull request #501 from alphagov/jess/fix_created_date_bug
Set Link created date
2 parents abf98ee + deb43d6 commit 7134358

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

app/services/legacy/dataset_import_service.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def create_resource_base_attributes(resource, dataset)
8181
uuid: resource["id"],
8282
format: resource["format"],
8383
name: datafile_name(resource),
84-
created_at: resource["created"],
84+
created_at: resource["created"] || dataset.created_at,
8585
updated_at: dataset.last_updated_at
8686
}
8787
end

spec/services/legacy/dataset_import_service_spec.rb

+11
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,17 @@
5353
expect(first_imported_datafile.end_date).to eql(Date.parse(first_resource["date"]).end_of_month)
5454
end
5555

56+
it "sets datafile created_at date to resource created date, if present" do
57+
legacy_dataset['resources'].first['created'] = nil
58+
dataset_with_resource_without_created_date = legacy_dataset
59+
Legacy::DatasetImportService.new(dataset_with_resource_without_created_date, orgs_cache, themes_cache).run
60+
imported_dataset = Dataset.find_by(uuid: legacy_dataset["id"])
61+
imported_datafiles = imported_dataset.links
62+
first_imported_datafile = imported_datafiles.first
63+
64+
expect(first_imported_datafile.created_at).to eql(imported_dataset.created_at)
65+
end
66+
5667
it "builds a dataset from a non timeseries legacy dataset" do
5768
Legacy::DatasetImportService.new(non_timeseries_legacy_dataset, orgs_cache, themes_cache).run
5869
expect(Dataset.last.frequency).to eq('never')

0 commit comments

Comments
 (0)