Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose async client #453

Open
1 task done
jon23d opened this issue May 16, 2024 · 2 comments
Open
1 task done

Expose async client #453

jon23d opened this issue May 16, 2024 · 2 comments

Comments

@jon23d
Copy link

jon23d commented May 16, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

I am running an async codebase, and alpaca-py is blocking

Describe the solution you'd like.

Either expose an async client (httpx is great), or add to the documentation a discussion of the concept (for example, workarounds, thread-safety, etc).

Describe an alternate solution.

No response

Anything else? (Additional Context)

Y'all are doing great work. Thanks!

@projects2080
Copy link

projects2080 commented Dec 30, 2024

All they need to do is make _run_forever() public and stop swallowing the general Exception type there

@projects2080
Copy link

To be clear, this request REALLY should be implemented. It is a basic async app requirement that the task should be manageable externally, because real-world async apps will usually already be running in with an asyncio context, and therefore need to start/stop and handle exceptions externally. It's shocking (telling?) more people don't need this.... I will provide a good backwards-compatible PR if someone at Alpaca can confirm I should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants