Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Resolve ENS trait as extension trait #491

Closed
mattsse opened this issue Apr 9, 2024 · 1 comment
Closed

[Feature] Add Resolve ENS trait as extension trait #491

mattsse opened this issue Apr 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mattsse
Copy link
Member

mattsse commented Apr 9, 2024

Component

network, json-rpc, provider, pubsub

Describe the feature you would like

ref https://github.com/foundry-rs/foundry/pull/7106/files#diff-122addc5d51c48daa1cf5a210987b086bc26fba01e8912d137afd24f6101e060R101

TODO

add an extension trait for this, similar to:

alloy/crates/provider/src/admin.rs

Line 11 in 5f74d4e

pub trait AdminApi<N, T>: Send + Sync {

Additional context

No response
@mattsse mattsse added the enhancement New feature or request label Apr 9, 2024
@prestwich
Copy link
Member

Note that ENS resolutions are stateful as the resolver address may differ

@zerosnacks zerosnacks mentioned this issue Jul 30, 2024
Open
@mattsse mattsse closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prestwich @mattsse