Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add signer field in Signed tx - Use OnceLock #481

Closed
yash-atreya opened this issue Apr 8, 2024 · 1 comment
Closed

[Feature] Add signer field in Signed tx - Use OnceLock #481

yash-atreya opened this issue Apr 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@yash-atreya
Copy link
Member

Component

consensus, eips, genesis

Describe the feature you would like

Motivation

Ref #472 (comment)

Solution

Add a signed_by: OnceLock<Address> field in Signed tx

Additional context

No response
@yash-atreya yash-atreya added the enhancement New feature or request label Apr 8, 2024
@yash-atreya yash-atreya changed the title [Feature] Add signed_by field in Signed tx - Use OnceLock [Feature] Add signer field in Signed tx - Use OnceLock Apr 8, 2024
@yash-atreya yash-atreya mentioned this issue Apr 8, 2024
Closed
3 tasks
@mattsse
Copy link
Member

mattsse commented Jan 31, 2025

storing the signer in a oncelock isn't the ideal API, we have the Recovered type for this now

@mattsse mattsse closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @yash-atreya