Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Improve and complete alloy prelude crate feature flag compatiblity #391

Closed
zerosnacks opened this issue Mar 25, 2024 · 0 comments · Fixed by #421
Closed

[Feature] Improve and complete alloy prelude crate feature flag compatiblity #391

zerosnacks opened this issue Mar 25, 2024 · 0 comments · Fixed by #421
Labels
enhancement New feature or request

Comments

@zerosnacks
Copy link
Member

zerosnacks commented Mar 25, 2024 •
edited
Loading

Component

provider, pubsub, rpc

Describe the feature you would like

In order to allow users to use the alloy namespace to access all features we need to make sure there is full feature flag coverage of crates and we maintain that coverage. Another goal is to reduce the amount of individual feature flags by having a few high level feature flags which enable general code paths alongside individual specific feature flags.

Concretely we are currently missing the following feature flag exports:

  • alloy-rpc-client:

    • reqwest
    • hyper
    • pubsub
    • ws
    • ipc

  • alloy-provider

    • provider-ws misses alloy-provider?/pubsub flag
    • provider-ipc misses alloy-provider?/pubsub flag

  • alloy/core

    • native-keccak

Other issues to resolve:

  • Default to std as a default feature but support no_std
  • Export missing serde feature flag
  • Export all crates from alloy/core
  • Refactor, clean up and regroup of feature flags

Additional context

Related PR: #421
@zerosnacks zerosnacks added the enhancement New feature or request label Mar 25, 2024
This was referenced Mar 25, 2024
Closed
Merged
Closed
@zerosnacks zerosnacks changed the title [Tracking] Full alloy namespace crate feature flag compatiblity [Feature] Full alloy namespace crate feature flag compatiblity Mar 28, 2024
@zerosnacks zerosnacks changed the title [Feature] Full alloy namespace crate feature flag compatiblity [Tracking] Full alloy namespace crate feature flag compatiblity Mar 28, 2024
@zerosnacks zerosnacks mentioned this issue Mar 29, 2024
Merged
2 tasks
@zerosnacks zerosnacks changed the title [Tracking] Full alloy namespace crate feature flag compatiblity [Tracking] Improve and complete alloy namespace crate feature flag compatiblity Mar 29, 2024
@zerosnacks zerosnacks changed the title [Tracking] Improve and complete alloy namespace crate feature flag compatiblity [Tracking] Improve and complete alloy prelude crate feature flag compatiblity Mar 29, 2024
@zerosnacks zerosnacks changed the title [Tracking] Improve and complete alloy prelude crate feature flag compatiblity [Feature] Improve and complete alloy prelude crate feature flag compatiblity Mar 29, 2024
@zerosnacks zerosnacks mentioned this issue Mar 29, 2024
Merged
3 tasks
@zerosnacks zerosnacks mentioned this issue Apr 2, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve and complete alloy prelude crate feature flag compatiblity zerosnacks/alloy
1 participant
@zerosnacks