Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement deserde manually for CallFrame #1986

Open
mattsse opened this issue Feb 1, 2025 · 0 comments
Open

[Feature] Implement deserde manually for CallFrame #1986

mattsse opened this issue Feb 1, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@mattsse
Copy link
Member

mattsse commented Feb 1, 2025

Component

rpc

Describe the feature you would like

due to this recursive structure:

/// Recorded child calls.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub calls: Vec<CallFrame>,

the CallFrame end encountered a serde deseerde issue ref #1156

#[derive(Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)]
pub struct CallFrame {

we should manually implement this iteratively and not use recursion via delegated deserialazion calls

Additional context

No response

@mattsse mattsse added the enhancement New feature or request label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant