[Bug] Overly using serde(flatten) causes bitcode and bincode errors

[louisponet]

Component

serde

What version of Alloy are you on?

├── alloy-primitives v0.8.15 () ├── alloy-consensus v0.8.3 () ├── alloy-network v0.8.3 () ├── alloy-primitives v0.8.15 () ├── alloy-provider v0.8.3 () ├── alloy-rpc-types v0.8.3 () ├── alloy-signer-local v0.8.3 () ├── alloy-transport-http v0.8.3 ()

Operating System

Linux

Describe the bug

Overly using the serde(flatten) attribute on different fields causes bitcode and bincode (tested with those) to panic with Sequence must have length. One clear example is Signed in alloy-consensus. Each of the fields is serializable, and if I create a Signed without serde(flatten) on the fields everything is fine.

Any reason to use serde(flatten) everywhere? If not, I can create a PR removing some.

Cheers

[klkvr]

serde(flatten) is used to comply with RPC specification and we can't remove it for e.g TxEnvelope as this would result in transactions being serialized incorrectly

there's no bincode format specification, however we still provide bincode-compatible helpers for some of the types, e.g

alloy/crates/consensus/src/transaction/eip1559.rs

Lines 295 to 297 in 015a658

	/// Bincode-compatible [`TxEip1559`] serde implementation.
	#[cfg(all(feature = "serde", feature = "serde-bincode-compat"))]
	pub(super) mod serde_bincode_compat {

feel free to add similar helpers for any other types you need such compatibiliy for

[louisponet]

Ah nice, thank you! will have a look into that

[mattsse]

closing because we have the bincode helpers for that